Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1405373005: views/mus: Move PlatformWindowMus into its own file. (Closed)

Created:
5 years, 1 month ago by sadrul
Modified:
5 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@mus-example-focus-close
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views/mus: Move PlatformWindowMus into its own file. BUG=none Committed: https://crrev.com/f2fb28df5f979c2a21da8f438c438715cd1708cb Cr-Commit-Position: refs/heads/master@{#358916}

Patch Set 1 #

Patch Set 2 : tot-merge #

Total comments: 2

Patch Set 3 : . #

Patch Set 4 : tot.merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -144 lines) Patch
M ui/views/mus/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A ui/views/mus/platform_window_mus.h View 1 chunk +70 lines, -0 lines 0 comments Download
A ui/views/mus/platform_window_mus.cc View 1 2 1 chunk +169 lines, -0 lines 0 comments Download
M ui/views/mus/window_tree_host_mus.cc View 1 chunk +1 line, -144 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
sadrul
5 years, 1 month ago (2015-11-10 18:33:29 UTC) #2
sky
LGTM https://codereview.chromium.org/1405373005/diff/20001/ui/views/mus/platform_window_mus.cc File ui/views/mus/platform_window_mus.cc (right): https://codereview.chromium.org/1405373005/diff/20001/ui/views/mus/platform_window_mus.cc#newcode59 ui/views/mus/platform_window_mus.cc:59: gfx::Rect PlatformWindowMus::GetBounds() { nit: use newlines!
5 years, 1 month ago (2015-11-10 19:03:00 UTC) #3
sadrul
https://codereview.chromium.org/1405373005/diff/20001/ui/views/mus/platform_window_mus.cc File ui/views/mus/platform_window_mus.cc (right): https://codereview.chromium.org/1405373005/diff/20001/ui/views/mus/platform_window_mus.cc#newcode59 ui/views/mus/platform_window_mus.cc:59: gfx::Rect PlatformWindowMus::GetBounds() { On 2015/11/10 19:03:00, sky wrote: > ...
5 years, 1 month ago (2015-11-10 20:59:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405373005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405373005/40001
5 years, 1 month ago (2015-11-10 21:02:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/120731) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-11-10 21:06:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405373005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405373005/60001
5 years, 1 month ago (2015-11-10 21:07:00 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-10 21:50:35 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 21:51:28 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f2fb28df5f979c2a21da8f438c438715cd1708cb
Cr-Commit-Position: refs/heads/master@{#358916}

Powered by Google App Engine
This is Rietveld 408576698