Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1405373004: OOPIF: Fix blinking caret in input fields. (Closed)

Created:
5 years, 1 month ago by alexmos
Modified:
5 years, 1 month ago
Reviewers:
kenrb, dcheng
CC:
blink-reviews, chromium-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@focus-keyboard-routing
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

OOPIF: Fix blinking caret in input fields. Currently, a focused input text field in a cross-process subframe doesn't have a blinking caret as expected. The root cause of this is that FrameSelection::scheduleVisualUpdate wasn't working correctly for frames with WebFrameWidgets. This CL fixes that by passing in the local frame root to page->animator().scheduleVisualUpdate(). BUG=530663 TEST=Click on <input> text field in an OOP frame, observe blinking caret. Committed: https://crrev.com/8e83910cb9f853ecb8ad781fc274cc9b0f615aa7 Cr-Commit-Position: refs/heads/master@{#357016}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (5 generated)
alexmos
Hi Ken, can you please take a look? This one's very short.
5 years, 1 month ago (2015-10-26 23:24:22 UTC) #2
kenrb
nice, lgtm
5 years, 1 month ago (2015-10-27 17:22:57 UTC) #3
alexmos
+Daniel for OWNERS.
5 years, 1 month ago (2015-10-27 20:57:20 UTC) #5
dcheng
lgtm
5 years, 1 month ago (2015-10-27 20:57:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405373004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405373004/1
5 years, 1 month ago (2015-10-30 00:36:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/114163)
5 years, 1 month ago (2015-10-30 00:46:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405373004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405373004/1
5 years, 1 month ago (2015-10-30 01:45:04 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 01:50:23 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 01:51:06 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e83910cb9f853ecb8ad781fc274cc9b0f615aa7
Cr-Commit-Position: refs/heads/master@{#357016}

Powered by Google App Engine
This is Rietveld 408576698