Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7539)

Unified Diff: chrome/browser/media/webrtc_log_uploader.cc

Issue 1405373002: Fix WebRTC log list errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/crash_upload_list_mac.cc ('k') | chrome/browser/media/webrtc_log_uploader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/webrtc_log_uploader.cc
diff --git a/chrome/browser/media/webrtc_log_uploader.cc b/chrome/browser/media/webrtc_log_uploader.cc
index 30d046d3e2a221778175f60a83815c2ae1afa75a..ef55b432cc5e50b969c34be7cb2bf80c0dc9c5ff 100644
--- a/chrome/browser/media/webrtc_log_uploader.cc
+++ b/chrome/browser/media/webrtc_log_uploader.cc
@@ -501,9 +501,10 @@ void WebRtcLogUploader::AddLocallyStoredLogInfoToUploadListFile(
}
}
- // Write the log ID to the log list file. Leave the upload time and report ID
- // empty.
- contents += ",," + local_log_id + '\n';
+ // Write the capture time and log ID to the log list file. Leave the upload
+ // time and report ID empty.
+ contents += ",," + local_log_id +
+ "," + base::DoubleToString(base::Time::Now().ToDoubleT()) + '\n';
int written =
base::WriteFile(upload_list_path, &contents[0], contents.size());
@@ -541,7 +542,7 @@ void WebRtcLogUploader::AddUploadedLogInfoToUploadListFile(
contents.insert(pos, time_now_str);
contents.insert(pos + time_now_str.length() + 1, report_id);
} else {
- contents += time_now_str + "," + report_id + ",\n";
+ contents += time_now_str + "," + report_id + ",," + time_now_str + "\n";
}
int written =
« no previous file with comments | « chrome/browser/crash_upload_list_mac.cc ('k') | chrome/browser/media/webrtc_log_uploader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698