Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1405353002: [Android] Replace a synchronous callsite of GetAccounts() (Closed)

Created:
5 years, 2 months ago by knn
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Replace a synchronous callsite of GetAccounts(). Two misc changes from http://crrev.com/1380103004 Use a static JNI call from java to C++. Make the GetAccounts method asynchronous. TBR=rogerta@chromium.org BUG=517697 Committed: https://crrev.com/b518f755450b62b644a1a734dd405cb762dcb81d Cr-Commit-Position: refs/heads/master@{#354517}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -91 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/signin/AccountTrackerService.java View 7 chunks +46 lines, -47 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/signin/account_tracker_service_android.h View 1 chunk +6 lines, -24 lines 0 comments Download
M chrome/browser/android/signin/account_tracker_service_android.cc View 2 chunks +12 lines, -18 lines 1 comment Download
M components/signin/core/browser/account_fetcher_service.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
knn
Separating unrelated changes from http://crrev.com/1380103004 to a different patch. PTAL. Thanks!
5 years, 2 months ago (2015-10-16 12:33:12 UTC) #3
nyquist
lgtm
5 years, 2 months ago (2015-10-16 14:00:30 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405353002/1
5 years, 2 months ago (2015-10-16 14:06:10 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-16 15:30:58 UTC) #8
knn
Roger, I am TBRing you for an unused header include removal.
5 years, 2 months ago (2015-10-16 15:40:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405353002/1
5 years, 2 months ago (2015-10-16 15:40:40 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-16 15:45:03 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b518f755450b62b644a1a734dd405cb762dcb81d Cr-Commit-Position: refs/heads/master@{#354517}
5 years, 2 months ago (2015-10-16 15:46:04 UTC) #13
Roger Tawa OOO till Jul 10th
5 years, 2 months ago (2015-10-16 17:49:03 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/1405353002/diff/1/chrome/browser/android/sign...
File chrome/browser/android/signin/account_tracker_service_android.cc (right):

https://codereview.chromium.org/1405353002/diff/1/chrome/browser/android/sign...
chrome/browser/android/signin/account_tracker_service_android.cc:34:
account_tracker_service_->SeedAccountInfo(gaia_ids[i], account_names[i]);
Remove trailing _

Powered by Google App Engine
This is Rietveld 408576698