Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2206)

Unified Diff: android_webview/native/aw_web_contents_delegate.cc

Issue 1405333005: Defer loads on WebView popup windows until webcontents delegate attached (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed nit. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/native/aw_web_contents_delegate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/native/aw_web_contents_delegate.cc
diff --git a/android_webview/native/aw_web_contents_delegate.cc b/android_webview/native/aw_web_contents_delegate.cc
index 55170f07c832a099d9e28dc9181b132393988549..d8f85cff6da1f1f49317d0355ee7376b1b4af5f7 100644
--- a/android_webview/native/aw_web_contents_delegate.cc
+++ b/android_webview/native/aw_web_contents_delegate.cc
@@ -218,6 +218,13 @@ void AwWebContentsDelegate::LoadingStateChanged(WebContents* source,
}
}
+bool AwWebContentsDelegate::ShouldResumeRequestsForCreatedWindow() {
+ // Always return false here since we need to defer loading the created window
+ // until after we have attached a new delegate to the new webcontents (which
+ // happens asynchronously).
+ return false;
+}
+
void AwWebContentsDelegate::RequestMediaAccessPermission(
WebContents* web_contents,
const content::MediaStreamRequest& request,
« no previous file with comments | « android_webview/native/aw_web_contents_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698