Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 1405333005: Defer loads on WebView popup windows until webcontents delegate attached (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move request resuming to receivePopupContents. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/native/aw_contents.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/java/src/org/chromium/android_webview/AwContents.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java
index 8ad3b4597e88892494eeef7fda2bebd8cf853ecb..23e7eef1f1e7326037b9439827899de0bd525fd3 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java
@@ -1035,6 +1035,9 @@ public class AwContents implements SmartClipProvider,
}
setNewAwContents(popupNativeAwContents);
+ // We defer loading any URL on the popup until it has been properly intialized (through
+ // setNewAwContents). We resume the load here.
+ nativeResumeLoadingCreatedPopupWebContents(popupNativeAwContents);
boliu 2015/10/30 16:17:13 nit: you can use mNativeAwContents here now
gsennton 2015/10/30 16:27:22 Done.
// Finally refresh all view state for mContentViewCore and mNativeAwContents.
if (!wasPaused) onResume();
@@ -3235,4 +3238,5 @@ public class AwContents implements SmartClipProvider,
private native void nativeCreateMessageChannel(long nativeAwContents, AwMessagePort[] ports);
private native void nativeGrantFileSchemeAccesstoChildProcess(long nativeAwContents);
+ private native void nativeResumeLoadingCreatedPopupWebContents(long nativeAwContents);
}
« no previous file with comments | « no previous file | android_webview/native/aw_contents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698