Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 140533002: drive: Apps.delete returns HTTP_NO_CONTENT on success. (Closed)

Created:
6 years, 11 months ago by kinaba
Modified:
6 years, 11 months ago
Reviewers:
hashimoto
CC:
chromium-reviews
Visibility:
Public.

Description

drive: Apps.delete returns HTTP_NO_CONTENT on success. The status code is consistent with other methods like Files.delete, so we should better align to it. This CL fixes the return code assumption in DriveAppRegistry that previously expected HTTP_SUCCESS. BUG=324166 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245295

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/browser/drive/drive_app_registry.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/drive/drive_app_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/drive/drive_app_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kinaba
6 years, 11 months ago (2014-01-16 04:10:26 UTC) #1
hashimoto
lgtm https://codereview.chromium.org/140533002/diff/20001/chrome/browser/drive/drive_app_registry.h File chrome/browser/drive/drive_app_registry.h (right): https://codereview.chromium.org/140533002/diff/20001/chrome/browser/drive/drive_app_registry.h#newcode55 chrome/browser/drive/drive_app_registry.h:55: // Callback type for UninstallApp(). Returns HTTP_NO_CONTENT on ...
6 years, 11 months ago (2014-01-16 04:37:25 UTC) #2
kinaba
https://codereview.chromium.org/140533002/diff/20001/chrome/browser/drive/drive_app_registry.h File chrome/browser/drive/drive_app_registry.h (right): https://codereview.chromium.org/140533002/diff/20001/chrome/browser/drive/drive_app_registry.h#newcode55 chrome/browser/drive/drive_app_registry.h:55: // Callback type for UninstallApp(). Returns HTTP_NO_CONTENT on success. ...
6 years, 11 months ago (2014-01-16 04:47:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/140533002/120001
6 years, 11 months ago (2014-01-16 04:49:10 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 19:55:12 UTC) #5
Message was sent while issue was closed.
Change committed as 245295

Powered by Google App Engine
This is Rietveld 408576698