Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: src/ast.h

Issue 1405313002: [es6] Fix scoping for default parameters in arrow functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix class literal handling Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | src/ast-expression-visitor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast.h
diff --git a/src/ast.h b/src/ast.h
index f1adf528a20ea5a6c9d61408f4ef289a2765b11d..4d35f7e7003c878f51265f1a44dcc41013e06bb6 100644
--- a/src/ast.h
+++ b/src/ast.h
@@ -3170,32 +3170,36 @@ class AstVisitor BASE_EMBEDDED {
};
-#define DEFINE_AST_VISITOR_SUBCLASS_MEMBERS() \
- public: \
- void Visit(AstNode* node) final { \
- if (!CheckStackOverflow()) node->Accept(this); \
- } \
- \
- void SetStackOverflow() { stack_overflow_ = true; } \
- void ClearStackOverflow() { stack_overflow_ = false; } \
- bool HasStackOverflow() const { return stack_overflow_; } \
- \
- bool CheckStackOverflow() { \
- if (stack_overflow_) return true; \
- if (GetCurrentStackPosition() < stack_limit_) { \
- stack_overflow_ = true; \
- return true; \
- } \
- return false; \
- } \
- \
- private: \
- void InitializeAstVisitor(Isolate* isolate) { \
- stack_limit_ = isolate->stack_guard()->real_climit(); \
- stack_overflow_ = false; \
- } \
- \
- uintptr_t stack_limit_; \
+#define DEFINE_AST_VISITOR_SUBCLASS_MEMBERS() \
+ public: \
+ void Visit(AstNode* node) final { \
+ if (!CheckStackOverflow()) node->Accept(this); \
+ } \
+ \
+ void SetStackOverflow() { stack_overflow_ = true; } \
+ void ClearStackOverflow() { stack_overflow_ = false; } \
+ bool HasStackOverflow() const { return stack_overflow_; } \
+ \
+ bool CheckStackOverflow() { \
+ if (stack_overflow_) return true; \
+ if (GetCurrentStackPosition() < stack_limit_) { \
+ stack_overflow_ = true; \
+ return true; \
+ } \
+ return false; \
+ } \
+ \
+ private: \
+ void InitializeAstVisitor(Isolate* isolate) { \
+ InitializeAstVisitor(isolate->stack_guard()->real_climit()); \
+ } \
+ \
+ void InitializeAstVisitor(uintptr_t stack_limit) { \
+ stack_limit_ = stack_limit; \
+ stack_overflow_ = false; \
+ } \
+ \
+ uintptr_t stack_limit_; \
bool stack_overflow_
« no previous file with comments | « BUILD.gn ('k') | src/ast-expression-visitor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698