[es6] Fix scoping for default parameters in arrow functions

src/ast-expression-visitor.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/ast-expression-visitor.h"
 
 #include "src/ast.h"
 #include "src/codegen.h"
@@ skipping 14 matching lines @@
 #define RECURSE_EXPRESSION(call)    \
   do {                              \
     DCHECK(!HasStackOverflow());    \
     ++depth_;                       \
     call;                           \
     --depth_;                       \
     if (HasStackOverflow()) return; \
   } while (false)
 
 
-AstExpressionVisitor::AstExpressionVisitor(Isolate* isolate,
-                                           FunctionLiteral* root)
+AstExpressionVisitor::AstExpressionVisitor(Isolate* isolate, Expression* root)
     : root_(root), depth_(0) {
   InitializeAstVisitor(isolate);
 }
 
 
-void AstExpressionVisitor::Run() { RECURSE(VisitFunctionLiteral(root_)); }
+AstExpressionVisitor::AstExpressionVisitor(uintptr_t stack_limit,
+                                           Expression* root)
+    : root_(root), depth_(0) {
+  InitializeAstVisitor(stack_limit);
+}
+
+
+void AstExpressionVisitor::Run() { RECURSE(Visit(root_)); }
 
 
 void AstExpressionVisitor::VisitVariableDeclaration(VariableDeclaration* decl) {
 }
 
 
 void AstExpressionVisitor::VisitFunctionDeclaration(FunctionDeclaration* decl) {
   RECURSE(Visit(decl->fun()));
 }
 
@@ skipping 163 matching lines @@
 void AstExpressionVisitor::VisitRegExpLiteral(RegExpLiteral* expr) {
   VisitExpression(expr);
 }
 
 
 void AstExpressionVisitor::VisitObjectLiteral(ObjectLiteral* expr) {
   VisitExpression(expr);
   ZoneList<ObjectLiteralProperty*>* props = expr->properties();
   for (int i = 0; i < props->length(); ++i) {
     ObjectLiteralProperty* prop = props->at(i);
+    RECURSE_EXPRESSION(Visit(prop->key()));
     RECURSE_EXPRESSION(Visit(prop->value()));
   }
 }
 
 
 void AstExpressionVisitor::VisitArrayLiteral(ArrayLiteral* expr) {
   VisitExpression(expr);
   ZoneList<Expression*>* values = expr->values();
   for (int i = 0; i < values->length(); ++i) {
     Expression* value = values->at(i);
@@ skipping 93 matching lines @@
 
 
 void AstExpressionVisitor::VisitDeclarations(ZoneList<Declaration*>* decls) {
   for (int i = 0; i < decls->length(); ++i) {
     Declaration* decl = decls->at(i);
     RECURSE(Visit(decl));
   }
 }
 
 
-void AstExpressionVisitor::VisitClassLiteral(ClassLiteral* expr) {}
+void AstExpressionVisitor::VisitClassLiteral(ClassLiteral* expr) {

[rossberg, 2015/10/16 11:55:41]

Oh, how did this even work before?

[adamk, 2015/10/16 13:38:28]

Since this was only designed for asm, it didn't have to support this syntax.

+  VisitExpression(expr);
+  ZoneList<ObjectLiteralProperty*>* props = expr->properties();
+  for (int i = 0; i < props->length(); ++i) {
+    ObjectLiteralProperty* prop = props->at(i);
+    RECURSE_EXPRESSION(Visit(prop->key()));
+    RECURSE_EXPRESSION(Visit(prop->value()));
+  }
+}
 
 
-void AstExpressionVisitor::VisitSpread(Spread* expr) {}
+void AstExpressionVisitor::VisitSpread(Spread* expr) {
+  RECURSE(Visit(expr->expression()));
+}
 
 
 void AstExpressionVisitor::VisitEmptyParentheses(EmptyParentheses* expr) {}
 
 
 void AstExpressionVisitor::VisitSuperPropertyReference(
     SuperPropertyReference* expr) {}
 
 
 void AstExpressionVisitor::VisitSuperCallReference(SuperCallReference* expr) {}
 
 
 }  // namespace internal
 }  // namespace v8