Issue 14053015: Don't add subtext padding if there is no subpadding.

Issue 14053015: Don't add subtext padding if there is no subpadding. (Closed)

Created:
7 years, 8 months ago by csharp

Modified:
7 years, 8 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Don't add subtext padding if there is no subpadding. BUG=230746 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194896

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing Comments #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -10 lines)			Patch
M	chrome/browser/ui/autofill/autofill_popup_controller_impl.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/autofill/autofill_popup_controller_impl.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc	View	1	3 chunks	+36 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/autofill/autofill_popup_view.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

LGTM, thanks. https://codereview.chromium.org/14053015/diff/1/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc File chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc (right): https://codereview.chromium.org/14053015/diff/1/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc#newcode301 chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc:301: gfx::Rect(0, 0, 100, 100)); nit: Looks like ...

7 years, 8 months ago (2013-04-16 22:06:01 UTC) #2

csharp

https://codereview.chromium.org/14053015/diff/1/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc File chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc (right): https://codereview.chromium.org/14053015/diff/1/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc#newcode301 chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc:301: gfx::Rect(0, 0, 100, 100)); On 2013/04/16 22:06:01, Ilya Sherman ...

7 years, 8 months ago (2013-04-17 13:29:37 UTC) #3

csharp

7 years, 8 months ago (2013-04-18 12:41:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r194896 (presubmit successful).

Expand Messages | Collapse Messages