Issue 14053008: Save and restore callee-save xmm registers on Win64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14053008: Save and restore callee-save xmm registers on Win64 (Closed)

Created:
7 years, 8 months ago by Dmitry Lomov (no reviews)

Modified:
7 years, 8 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Save and restore callee-save xmm registers on Win64 BUG= Committed: https://code.google.com/p/v8/source/detail?r=14301

Patch Set 1 : Typo #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -2 lines)			Patch
M	src/x64/assembler-x64.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	3 chunks	+35 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with two nits. Thanks for looking into this! https://codereview.chromium.org/14053008/diff/1004/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): https://codereview.chromium.org/14053008/diff/1004/src/x64/code-stubs-x64.cc#newcode4309 src/x64/code-stubs-x64.cc:4309: ...

7 years, 8 months ago (2013-04-17 08:26:01 UTC) #2

Dmitry Lomov (no reviews)

7 years, 8 months ago (2013-04-17 09:54:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14301 (presubmit successful).

Expand Messages | Collapse Messages