Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 14053006: History: Workaround bug with clear button in search field. (Closed)

Created:
7 years, 8 months ago by Patrick Dubroy
Modified:
7 years, 8 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

History: Workaround bug with clear button in search field. Due to a Blink bug (http://crbug.com/231830), the clear button in the search field is not properly rendered if the <header> element has its transform style property set to anything other than 'none'. A simple workaround to make it render properly in 99% of cases is to set the value of -webkit-transform to 'none' instead of 0px. BUG=231291 TEST=Open chrome://history, type something in the search field, and ensure that the clear button (a circle with a "X") is visible. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194586

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/resources/uber/uber_utils.js View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Patrick Dubroy
Evan, please take a look.
7 years, 8 months ago (2013-04-16 10:55:26 UTC) #1
Evan Stade
lgtm
7 years, 8 months ago (2013-04-16 20:09:12 UTC) #2
Patrick Dubroy
7 years, 8 months ago (2013-04-17 14:01:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r194586 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698