Issue 14053004: Add ManagedUserSettings Sync data type.

Issue 14053004: Add ManagedUserSettings Sync data type. (Closed)

Created:
7 years, 8 months ago by Bernhard Bauer

Modified:
7 years, 8 months ago

Reviewers:
Andrew T Wilson (Slow), Nicolas Zea, tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing), rlarocque, pavely, albertb.google

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add ManagedUserSettings Sync data type. This data type should not be visible in the UI, as it will be configured automatically for managed users. TBR=atwilson@chromium.org BUG=229383 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194582

Patch Set 6 : review #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+151 lines, -35 lines)			Patch
M	chrome/browser/sync/glue/model_association_manager.cc	View	2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/sync_prefs.cc	View	2	1 chunk	+2 lines, -0 lines	0 comments	Download
A	chrome/browser/sync/test/integration/single_client_managed_user_settings_sync_test.cc	View	1 2 3 4	1 chunk	+28 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 2 3 4 5	1 chunk	+15 lines, -12 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1 2 3 4 5	1 chunk	+13 lines, -12 lines	0 comments	Download
M	sync/internal_api/base_node.cc	View	2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	sync/internal_api/public/base/model_type.h	View	2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sync/internal_api/public/base_node.h	View	2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sync/internal_api/public/write_node.h	View	2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sync/internal_api/write_node.cc	View	1 2 3 4	1 chunk	+7 lines, -0 lines	0 comments	Download
A +	sync/protocol/managed_user_setting_specifics.proto	View	1 2 3 4 5	2 chunks	+4 lines, -5 lines	0 comments	Download
M	sync/protocol/proto_value_conversions.h	View	2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	sync/protocol/proto_value_conversions.cc	View	2	2 chunks	+9 lines, -0 lines	0 comments	Download
M	sync/protocol/proto_value_conversions_unittest.cc	View	2	4 chunks	+7 lines, -1 line	0 comments	Download
M	sync/protocol/sync.proto	View	2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	sync/sync_proto.gypi	View	2	1 chunk	+1 line, -0 lines	0 comments	Download
M	sync/syncable/model_type.cc	View	2	11 chunks	+25 lines, -0 lines	0 comments	Download
M	sync/syncable/nigori_util.cc	View	2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sync/tools/testserver/chromiumsync.py	View	2	5 chunks	+7 lines, -1 line	0 comments	Download
M	sync/util/data_type_histogram.h	View	2	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

+CC Albert for new proto's LGTM https://codereview.chromium.org/14053004/diff/13001/chrome/browser/sync/test/integration/single_client_managed_user_settings_sync_test.cc File chrome/browser/sync/test/integration/single_client_managed_user_settings_sync_test.cc (right): https://codereview.chromium.org/14053004/diff/13001/chrome/browser/sync/test/integration/single_client_managed_user_settings_sync_test.cc#newcode27 chrome/browser/sync/test/integration/single_client_managed_user_settings_sync_test.cc:27: ASSERT_TRUE(SetupSync()); FYI, I ...

7 years, 8 months ago (2013-04-16 20:06:48 UTC) #3

Bernhard Bauer

TBR: Drew for sync_setup_handler.cc (changing a compile-time check about the number of synced datatypes). https://codereview.chromium.org/14053004/diff/13001/sync/protocol/managed_user_setting_specifics.proto ...

7 years, 8 months ago (2013-04-17 10:44:12 UTC) #4

Bernhard Bauer

7 years, 8 months ago (2013-04-17 12:46:07 UTC) #6

Message was sent while issue was closed.

Committed patchset #6 manually as r194582 (presubmit successful).

Expand Messages | Collapse Messages