third_party/WebKit/Source/core/editing/commands/RemoveCSSPropertyCommand.cpp - Issue 1405293012: [Variables] Enable get/setProperty and similar APIs from the CSSOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/RemoveCSSPropertyCommand.cpp

Issue 1405293012: [Variables] Enable get/setProperty and similar APIs from the CSSOM (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/StylePropertySet.cpp ('K') | « third_party/WebKit/Source/core/css/parser/CSSVariableParser.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/RemoveCSSPropertyCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/RemoveCSSPropertyCommand.cpp b/third_party/WebKit/Source/core/editing/commands/RemoveCSSPropertyCommand.cpp

index 6853498417baf794df2e1c36bbda7ed734b20b9e..8b403cebd54a721cc45959d196aca27b32c61926 100644

--- a/third_party/WebKit/Source/core/editing/commands/RemoveCSSPropertyCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/RemoveCSSPropertyCommand.cpp

@@ -58,12 +58,12 @@ void RemoveCSSPropertyCommand::doApply()

// Mutate using the CSSOM wrapper so we get the same event behavior as a script.

// Setting to null string removes the property. We don't have internal version of removeProperty.

- m_element->style()->setPropertyInternal(m_property, String(), false, IGNORE_EXCEPTION);

+ m_element->style()->setPropertyInternal(m_property, String(), String(), false, IGNORE_EXCEPTION);

}

void RemoveCSSPropertyCommand::doUnapply()

{

- m_element->style()->setPropertyInternal(m_property, m_oldValue, m_important, IGNORE_EXCEPTION);

+ m_element->style()->setPropertyInternal(m_property, String(), m_oldValue, m_important, IGNORE_EXCEPTION);

}

DEFINE_TRACE(RemoveCSSPropertyCommand)