third_party/WebKit/Source/core/css/CSSValue.cpp - Issue 1405293012: [Variables] Enable get/setProperty and similar APIs from the CSSOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSValue.cpp

Issue 1405293012: [Variables] Enable get/setProperty and similar APIs from the CSSOM (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix CSSPropertyMetadata::isEnabledProperty Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp ('K') | « third_party/WebKit/Source/core/css/CSSStyleDeclaration.h ('k') | third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.h » ('j') | third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSValue.cpp b/third_party/WebKit/Source/core/css/CSSValue.cpp

index dcc6bd14b2331aeddf7a30a78caa19cb5f9f8d11..d752ce52c3634745fdcf245e2cbc39081bb2426b 100644

--- a/third_party/WebKit/Source/core/css/CSSValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSValue.cpp

@@ -261,8 +261,7 @@ String CSSValue::cssText() const

case VariableReferenceClass:

return toCSSVariableReferenceValue(this)->customCSSText();

case CustomPropertyDeclarationClass:

- // TODO(leviw): We don't allow custom properties in CSSOM yet

- ASSERT_NOT_REACHED();

+ return toCSSCustomPropertyDeclaration(this)->value()->tokenRange().serialize();

Timothy Loh 2015/11/14 02:21:05 IMO the serialization logic here should be in CSSC

leviw_travelin_and_unemployed 2015/11/17 01:25:07 Done.

}

ASSERT_NOT_REACHED();

return String();