third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h - Issue 1405293012: [Variables] Enable get/setProperty and similar APIs from the CSSOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h

Issue 1405293012: [Variables] Enable get/setProperty and similar APIs from the CSSOM (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix CSSPropertyMetadata::isEnabledProperty Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl ('K') | « third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl ('k') | third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp » ('j') | third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h

diff --git a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h

index 6fc6e4f7416197a587a23644bf3d2531eaa5f4b4..cdcbe6c693a8820c511fe8d145b619e09b917fb3 100644

--- a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h

+++ b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h

@@ -97,7 +97,7 @@ private:

void setCSSText(const String&, ExceptionState&) override;

PassRefPtrWillBeRawPtr<CSSValue> getPropertyCSSValueInternal(CSSPropertyID) override;

String getPropertyValueInternal(CSSPropertyID) override;

- void setPropertyInternal(CSSPropertyID, const String& value, bool important, ExceptionState&) override;

+ void setPropertyInternal(CSSPropertyID, const String& propertyName, const String& value, bool important, ExceptionState&) override;

Timothy Loh 2015/11/14 02:21:05 maybe customPropertyName here and everywhere else,

leviw_travelin_and_unemployed 2015/11/17 01:25:07 SGTM.

bool cssPropertyMatches(CSSPropertyID, const CSSValue*) const override;