third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp - Issue 1405293012: [Variables] Enable get/setProperty and similar APIs from the CSSOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

Issue 1405293012: [Variables] Enable get/setProperty and similar APIs from the CSSOM (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix CSSPropertyMetadata::isEnabledProperty Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/variables/custom-properties-in-object-model-expected.txt ('k') | third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl » ('j') | third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

index 0cc9c9baddb22283131baef596a38da60d55adc2..942efd957d43cb92ee3ecbf0490b15c89cdd178c 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

@@ -224,7 +224,8 @@ void V8CSSStyleDeclaration::namedPropertySetterCustom(v8::Local<v8::Name> name,

TOSTRING_VOID(V8StringResource<TreatNullAsNullString>, propertyValue, value);

ExceptionState exceptionState(ExceptionState::SetterContext, getPropertyName(resolveCSSPropertyID(unresolvedProperty)), "CSSStyleDeclaration", info.Holder(), info.GetIsolate());

- impl->setPropertyInternal(unresolvedProperty, propertyValue, false, exceptionState);

+ // TODO(leviw): This API doesn't support custom properties.

Timothy Loh 2015/11/14 02:21:05 Just checking, the function we're in is for foo.st

leviw_travelin_and_unemployed 2015/11/17 01:25:07 That's correct.

+ impl->setPropertyInternal(unresolvedProperty, String(), propertyValue, false, exceptionState);

if (exceptionState.throwIfNeeded())

return;