third_party/WebKit/Source/core/css/CSSStyleDeclaration.h - Issue 1405293012: [Variables] Enable get/setProperty and similar APIs from the CSSOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSStyleDeclaration.h

Issue 1405293012: [Variables] Enable get/setProperty and similar APIs from the CSSOM (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use static_assert. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.cpp ('k') | third_party/WebKit/Source/core/css/CSSValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSStyleDeclaration.h

diff --git a/third_party/WebKit/Source/core/css/CSSStyleDeclaration.h b/third_party/WebKit/Source/core/css/CSSStyleDeclaration.h

index 26ac96db1b4a2b16936e819ecd9d03bb690092e3..808fc944b0205ab9c9af9731ff9265d14a8286fb 100644

--- a/third_party/WebKit/Source/core/css/CSSStyleDeclaration.h

+++ b/third_party/WebKit/Source/core/css/CSSStyleDeclaration.h

@@ -53,7 +53,7 @@ public:

}

void setCSSFloat(const String& value, ExceptionState& exceptionState)

{

- setPropertyInternal(CSSPropertyFloat, value, false, exceptionState);

+ setPropertyInternal(CSSPropertyFloat, String(), value, false, exceptionState);

}

virtual String cssText() const = 0;

virtual void setCSSText(const String&, ExceptionState&) = 0;

@@ -71,7 +71,7 @@ public:

// The CSSValue returned by this function should not be exposed to the web as it may be used by multiple documents at the same time.

virtual PassRefPtrWillBeRawPtr<CSSValue> getPropertyCSSValueInternal(CSSPropertyID) = 0;

virtual String getPropertyValueInternal(CSSPropertyID) = 0;

- virtual void setPropertyInternal(CSSPropertyID, const String& value, bool important, ExceptionState&) = 0;

+ virtual void setPropertyInternal(CSSPropertyID, const String& propertyValue, const String& value, bool important, ExceptionState&) = 0;

virtual bool cssPropertyMatches(CSSPropertyID, const CSSValue*) const = 0;

virtual CSSStyleSheet* parentStyleSheet() const { return 0; }