Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1405273005: Parse text-decoration shorthand in CSSPropertyParser with CSSParserTokens (Closed)

Created:
5 years, 1 month ago by rwlbuis
Modified:
5 years, 1 month ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Parse text-decoration shorthand in CSSPropertyParser with CSSParserTokens Move text-decoration shorthand property handling from LegacyCSSPropertyParser into CSSPropertyParser. Also move its related longhands. This patch adds a generic consumeShorthandGreedily that can be used to convert other shorthands. Finally the patch refuses duplicate keyword entries for text-decoration-line (like "blink blink") and adds tests for this to text-decoration-line.html. BUG=499780, 551638 Committed: https://crrev.com/aba3cd0fad04fb412eeba2f93f1760242349bcee Cr-Commit-Position: refs/heads/master@{#358232}

Patch Set 1 #

Messages

Total messages: 9 (4 generated)
rwlbuis
PTAL. This patch brings back the reverted patch and has the fix for Bug 551638.
5 years, 1 month ago (2015-11-05 21:57:27 UTC) #4
Timothy Loh
On 2015/11/05 21:57:27, rwlbuis wrote: > PTAL. This patch brings back the reverted patch and ...
5 years, 1 month ago (2015-11-05 23:59:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405273005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405273005/1
5 years, 1 month ago (2015-11-06 00:58:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 02:05:50 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 02:06:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aba3cd0fad04fb412eeba2f93f1760242349bcee
Cr-Commit-Position: refs/heads/master@{#358232}

Powered by Google App Engine
This is Rietveld 408576698