Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1405273003: Revert of "[heap] Divide available memory upon compaction tasks" (Closed)

Created:
5 years, 2 months ago by Michael Lippautz
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of "[heap] Divide available memory upon compaction tasks" (patchset #5 id:90008 of https://codereview.chromium.org/1415733004/ ) Reason for revert: Failing again: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/2183 Original issue's description: > Reland of "[heap] Divide available memory upon compaction tasks" > > This reverts commit cf71c28f13425d0e8c041391a2b37f0908b9e4b5. > > Original message: > > [heap] Divide available memory upon compaction tasks > - Fairly (round-robin) divide available memory upon compaction tasks. > - Ensure an upper limit (of memory) since dividing is O(n) for n free-space > nodes. > - Refill from free lists managed by sweeper once a compaction space becomes > empty. > > Assumption for dividing memory: Memory in the free lists is sparse upon starting > compaction (which means that only few nodes are available), except for memory > reducer GCs, which happen in idle time though (so it's less of a problem). > > BUG=chromium:524425 > LOG=N > > Committed: https://crrev.com/63f42ecb965d04877f45043c1416170b6f79b962 > Cr-Commit-Position: refs/heads/master@{#31436} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524425 Committed: https://crrev.com/a31cef44dcd79ae0ea53d83b70b5af130a499754 Cr-Commit-Position: refs/heads/master@{#31439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -378 lines) Patch
M src/heap/heap.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/mark-compact.h View 2 chunks +2 lines, -14 lines 0 comments Download
M src/heap/mark-compact.cc View 4 chunks +30 lines, -7 lines 0 comments Download
M src/heap/spaces.h View 6 chunks +5 lines, -32 lines 0 comments Download
M src/heap/spaces.cc View 6 chunks +8 lines, -136 lines 0 comments Download
M test/cctest/heap-tester.h View 2 chunks +11 lines, -32 lines 0 comments Download
M test/cctest/test-spaces.cc View 4 chunks +11 lines, -156 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Lippautz
Created Revert of "[heap] Divide available memory upon compaction tasks"
5 years, 2 months ago (2015-10-21 13:14:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405273003/1
5 years, 2 months ago (2015-10-21 13:14:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-21 13:14:29 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 13:14:54 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a31cef44dcd79ae0ea53d83b70b5af130a499754
Cr-Commit-Position: refs/heads/master@{#31439}

Powered by Google App Engine
This is Rietveld 408576698