Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: handler/mac/exception_handler_server.h

Issue 1405273002: Mach port scopers should use get() instead of type conversion operators (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: More is_valid() Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « handler/mac/crash_report_exception_handler.cc ('k') | handler/mac/exception_handler_server.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 //! encountered, it will log a message and terminate execution. Receipt of an 50 //! encountered, it will log a message and terminate execution. Receipt of an
51 //! invalid message on receive_port() will cause a message to be logged, but 51 //! invalid message on receive_port() will cause a message to be logged, but
52 //! this method will continue running normally. 52 //! this method will continue running normally.
53 void Run(UniversalMachExcServer::Interface* exception_interface); 53 void Run(UniversalMachExcServer::Interface* exception_interface);
54 54
55 //! \brief Returns the receive right that will be monitored for exception 55 //! \brief Returns the receive right that will be monitored for exception
56 //! messages. 56 //! messages.
57 //! 57 //!
58 //! The caller does not take ownership of this port. The caller must not use 58 //! The caller does not take ownership of this port. The caller must not use
59 //! this port for any purpose other than to make send rights for clients. 59 //! this port for any purpose other than to make send rights for clients.
60 mach_port_t receive_port() const { return receive_port_; } 60 mach_port_t receive_port() const { return receive_port_.get(); }
61 61
62 private: 62 private:
63 base::mac::ScopedMachReceiveRight receive_port_; 63 base::mac::ScopedMachReceiveRight receive_port_;
64 64
65 DISALLOW_COPY_AND_ASSIGN(ExceptionHandlerServer); 65 DISALLOW_COPY_AND_ASSIGN(ExceptionHandlerServer);
66 }; 66 };
67 67
68 } // namespace crashpad 68 } // namespace crashpad
69 69
70 #endif // CRASHPAD_HANDLER_MAC_EXCEPTION_HANDLER_SERVER_H_ 70 #endif // CRASHPAD_HANDLER_MAC_EXCEPTION_HANDLER_SERVER_H_
OLDNEW
« no previous file with comments | « handler/mac/crash_report_exception_handler.cc ('k') | handler/mac/exception_handler_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698