Mach port scopers should use get() instead of type conversion operators

client/crashpad_client_mac.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 74 matching lines @@
 
 CrashpadClient::~CrashpadClient() {
 }
 
 bool CrashpadClient::StartHandler(
     const base::FilePath& handler,
     const base::FilePath& database,
     const std::string& url,
     const std::map<std::string, std::string>& annotations,
     const std::vector<std::string>& arguments) {
-  DCHECK_EQ(exception_port_, kMachPortNull);
+  DCHECK(!exception_port_.is_valid());
 
   // Set up the arguments for execve() first. These aren’t needed until execve()
   // is called, but it’s dangerous to do this in a child process after fork().
   ChildPortHandshake child_port_handshake;
   int handshake_fd = child_port_handshake.ReadPipeFD();
 
   // Use handler as argv[0], followed by arguments directed by this method’s
   // parameters and a --handshake-fd argument. |arguments| are added first so
   // that if it erroneously contains an argument such as --url, the actual |url|
   // argument passed to this method will supersede it. In normal command-line
@@ skipping 98 matching lines @@
     LOG(WARNING) << "intermediate process: signal " << WTERMSIG(status);
   } else if (!WIFEXITED(status)) {
     DLOG(WARNING) << "intermediate process: unknown termination " << status;
   } else if (WEXITSTATUS(status) != EXIT_SUCCESS) {
     LOG(WARNING) << "intermediate process: exit status " << WEXITSTATUS(status);
   }
 
   // Rendezvous with the handler running in the grandchild process.
   exception_port_.reset(child_port_handshake.RunServer());
 
-  return exception_port_ ? true : false;
+  return exception_port_.is_valid();
 }
 
 bool CrashpadClient::UseHandler() {
-  DCHECK_NE(exception_port_, kMachPortNull);
+  DCHECK(exception_port_.is_valid());
 
-  return SetCrashExceptionPorts(exception_port_);
+  return SetCrashExceptionPorts(exception_port_.get());
 }
 
 // static
 void CrashpadClient::UseSystemDefaultHandler() {
   base::mac::ScopedMachSendRight
       system_crash_reporter_handler(SystemCrashReporterHandler());
 
   // Proceed even if SystemCrashReporterHandler() failed, setting MACH_PORT_NULL
   // to clear the current exception ports.
-  if (!SetCrashExceptionPorts(system_crash_reporter_handler)) {
+  if (!SetCrashExceptionPorts(system_crash_reporter_handler.get())) {
     SetCrashExceptionPorts(MACH_PORT_NULL);
   }
 }
 
 }  // namespace crashpad