Removes gtest config from //testing/buildbot.

Removes gtest config from //testing/buildbot.

This configuration got moved to the chromium_android.py config in the chromium_tests recipe module, since that's where this config seems to be for the chromium.linux Android Tests (dbg) builder.

base_unittests (along with several other unit tests) required --isolate-file-path <isolate-file> to know what to push to the device. We could either revise //testing/scripts/android_gtest_test.py (which is used for exactly one suite on the main Android bots), use gtest_tests and adapt the test generator on the recipe_module side to do what we need it to, or do what the main Android bots do.

We've opted for the latter with this CL & the matching one on the infra side, but I don't have a strong opinion one way or another.

BUG=

Committed: https://crrev.com/e3606ab8098a3e22149b8a68846aec54a8305172
Cr-Commit-Position: refs/heads/master@{#357017}

[martiniss, 2015-10-29 19:55:54]

martiniss@chromium.org changed reviewers:
+ jbudorick@chromium.org

[martiniss, 2015-10-29 19:55:55]

PTAL once again.

[jbudorick, 2015-10-29 19:56:29]

not an owner, but lgtm

[martiniss, 2015-10-29 19:58:12]

martiniss@chromium.org changed reviewers:
+ dpranke@chromium.org

[martiniss, 2015-10-29 19:58:13]

PTAL

Also, is it ok if we add me or john as owners of the chromium.android.json file?

[Dirk Pranke, 2015-10-29 20:51:01]

I'm not sure I understand this; are you saying that the test isn't being run if
you list it here? Or are you saying that we already list this in the build-side
file, so we don't need to list it here?

In general, we should prefer listing things in the src-side files and trying to
eliminate reasons to listing them build-side.

Otherwise, yes, feel free to change the OWNERS file.

[jbudorick, 2015-10-29 20:55:18]

On 2015/10/29 20:51:01, Dirk Pranke wrote:
> I'm not sure I understand this; are you saying that the test isn't being run
if
> you list it here? Or are you saying that we already list this in the
build-side
> file, so we don't need to list it here?

It is being run, but it's not being run correctly. base_unittests (along with
several other unit tests) required --isolate-file-path <isolate-file> to know
what to push to the device. We could either revise
//testing/scripts/android_gtest_test.py (which is used for exactly one suite on
the main Android bots), use gtest_tests and adapt the test generator on the
recipe_module side to do what we need it to, or do what the main Android bots
do.

We've opted for the latter with this CL & the matching one on the infra side,
but I don't have a strong opinion one way or another.

> 
> In general, we should prefer listing things in the src-side files and trying
to
> eliminate reasons to listing them build-side.
> 
> Otherwise, yes, feel free to change the OWNERS file.

[Dirk Pranke, 2015-10-29 20:59:55]

On 2015/10/29 20:55:18, jbudorick wrote:
> On 2015/10/29 20:51:01, Dirk Pranke wrote:
> > I'm not sure I understand this; are you saying that the test isn't being run
> if
> > you list it here? Or are you saying that we already list this in the
> build-side
> > file, so we don't need to list it here?
> 
> It is being run, but it's not being run correctly. base_unittests (along with
> several other unit tests) required --isolate-file-path <isolate-file> to know
> what to push to the device. We could either revise
> //testing/scripts/android_gtest_test.py (which is used for exactly one suite
on
> the main Android bots), use gtest_tests and adapt the test generator on the
> recipe_module side to do what we need it to, or do what the main Android bots
> do.
> 
> We've opted for the latter with this CL & the matching one on the infra side,
> but I don't have a strong opinion one way or another.

Okay. We can go with this for now and revisit as part of figuring out how to
handle the
isolates in the GN build (though we'll probably have to make something work for
both
GN and GYP, of course).

Can you update the CL description to be clearer about why we're making this
change,
as per your response?

lgtm.

[martiniss, 2015-10-29 22:20:35]

Description was changed from

==========
Removes gtest config from //testing/buildbot.

This config got moved to the chromium_android.py config in the chromium_tests
recipe module, since that's where this config seems to be for the chromium.linux
Android Tests (dbg) builder.

BUG=
==========

to

==========
Removes gtest config from //testing/buildbot.

This configuration got moved to the chromium_android.py config in the
chromium_tests recipe module, since that's where this config seems to be for the
chromium.linux Android Tests (dbg) builder.

base_unittests (along with several other unit tests) required
--isolate-file-path <isolate-file> to know what to push to the device. We could
either revise //testing/scripts/android_gtest_test.py (which is used for exactly
one suite on the main Android bots), use gtest_tests and adapt the test
generator on the recipe_module side to do what we need it to, or do what the
main Android bots do.

We've opted for the latter with this CL & the matching one on the infra side,
but I don't have a strong opinion one way or another.

BUG=
==========

[martiniss, 2015-10-29 22:20:38]

The CQ bit was checked by martiniss@chromium.org

[commit-bot: I haz the power, 2015-10-29 22:21:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1405253008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1405253008/1

[commit-bot: I haz the power, 2015-10-29 23:30:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 23:30:49]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[martiniss, 2015-10-30 00:00:06]

The CQ bit was checked by martiniss@chromium.org

[commit-bot: I haz the power, 2015-10-30 00:02:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1405253008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1405253008/1

[commit-bot: I haz the power, 2015-10-30 02:00:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-30 02:01:14]

Patchset 1 (id:??) landed as
https://crrev.com/e3606ab8098a3e22149b8a68846aec54a8305172
Cr-Commit-Position: refs/heads/master@{#357017}