fpdfsdk/src/javascript/PublicMethods.cpp - Issue 1405253007: Revert "Revert "Cleanup some numeric code.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/PublicMethods.cpp

Issue 1405253007: Revert "Revert "Cleanup some numeric code."" (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Fix mac build Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/javascript/PublicMethods.cpp

diff --git a/fpdfsdk/src/javascript/PublicMethods.cpp b/fpdfsdk/src/javascript/PublicMethods.cpp

index e898214cd85d47ee827716955b4709c74b03e628..13239aeb1dc382ec1a429b9466d15fdc03522417 100644

--- a/fpdfsdk/src/javascript/PublicMethods.cpp

+++ b/fpdfsdk/src/javascript/PublicMethods.cpp

@@ -116,7 +116,7 @@ FX_BOOL CJS_PublicMethods::IsDigit(wchar_t ch) {

}

FX_BOOL CJS_PublicMethods::IsDigit(char ch) {

- return (ch >= '0' && ch <= '9');

+ return std::isdigit(ch);

}

FX_BOOL CJS_PublicMethods::IsAlphabetic(wchar_t ch) {