core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp - Issue 1405253007: Revert "Revert "Cleanup some numeric code.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp

Issue 1405253007: Revert "Revert "Cleanup some numeric code."" (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Fix mac build Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp

index 3057948959807b1e84e336729ad5ee6dc3efe3c2..cc9b0fcbe8b550ede3b63212dfa61ac2ed41f964 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp

@@ -1540,7 +1540,7 @@ CFX_ByteString _FPDF_ByteStringFromHex(CFX_BinaryBuf& src_buf) {

FX_DWORD size = src_buf.GetSize();

for (FX_DWORD i = 0; i < size; i++) {

uint8_t ch = str[i];

- if (ch >= '0' && ch <= '9') {

+ if (std::isdigit(ch)) {

if (bFirst) {

code = (ch - '0') * 16;

} else {