Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Unified Diff: mojo/devtools/common/mojo_benchmark

Issue 1405223009: mojo_benchmark: return non-zero exit code when --upload fails. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/mojo_benchmark
diff --git a/mojo/devtools/common/mojo_benchmark b/mojo/devtools/common/mojo_benchmark
index 8f83c5be4ef87c84ae84327a6e248e1043bbb702..ec17ad0fc52a1fbce22f015f430614e1ff4f9dfd 100755
--- a/mojo/devtools/common/mojo_benchmark
+++ b/mojo/devtools/common/mojo_benchmark
@@ -228,11 +228,12 @@ def main():
exit_code = 1
if script_args.upload:
- perf_dashboard.upload_chart_data(
+ if not perf_dashboard.upload_chart_data(
script_args.master_name, script_args.bot_name,
script_args.test_name, script_args.builder_name,
script_args.build_number, chart_data_recorder.get_chart_data(),
- script_args.server_url, script_args.dry_run)
+ script_args.server_url, script_args.dry_run):
+ exit_code = 1
return exit_code
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698