Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1405223003: Allow style sharing for canvas, iframe, embed and object. (Closed)

Created:
5 years, 2 months ago by esprehn
Modified:
5 years, 2 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow style sharing for canvas, iframe, embed and object. We didn't allow this before because they would use the layer update hack to force a style recalc (with identical style) to make their composited layer appear/disappear. Now we use the more modern Element::setNeedsCompositingUpdate() which directly dirties the compositing state without having to go through the style recalc machinery. This means we can style share between iframes on the page. Committed: https://crrev.com/2f0884e24caaaa2925ef7007a5296e0fdef379cf Cr-Commit-Position: refs/heads/master@{#354475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405223003/1
5 years, 2 months ago (2015-10-16 04:09:01 UTC) #2
esprehn
5 years, 2 months ago (2015-10-16 05:03:57 UTC) #4
dstockwell
lgtm
5 years, 2 months ago (2015-10-16 06:41:29 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-16 07:52:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405223003/1
5 years, 2 months ago (2015-10-16 08:39:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-16 08:43:45 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 08:44:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f0884e24caaaa2925ef7007a5296e0fdef379cf
Cr-Commit-Position: refs/heads/master@{#354475}

Powered by Google App Engine
This is Rietveld 408576698