Issue 1405183002: Bring up the service isolate and use it for package resolution in gen_snapshot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1405183002: Bring up the service isolate and use it for package resolution in gen_snapshot (Closed)

Created:
5 years, 2 months ago by Cutch

Modified:
5 years, 2 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Bring up the service isolate and use it for package resolution in gen_snapshot - Link dart:io implementation into gen_snapshot. - Start event handler in gen_snapshot. - Build system updates for gypi and gn. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/90130474252d3fa537762a399f008d53b78d3a61

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+154 lines, -6 lines)			Patch
M	runtime/bin/BUILD.gn	View		4 chunks	+86 lines, -0 lines	0 comments	Download
M	runtime/bin/bin.gypi	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	runtime/bin/builtin_gen_snapshot.cc	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/bin/dartutils.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/bin/gen_snapshot.cc	View		5 chunks	+58 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Cutch

5 years, 2 months ago (2015-10-16 13:49:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
90130474252d3fa537762a399f008d53b78d3a61 (presubmit successful).