Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 140513008: drive: Allow setting modified/accessed date with AddNewDirectory (Closed)

Created:
6 years, 10 months ago by hashimoto
Modified:
6 years, 10 months ago
Reviewers:
kinaba, benwells, tzik
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tzik, tfarina, nhiroki, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Allow setting modified/accessed date with AddNewDirectory Add AddNewDirectoryOptions() argument to AddNewDirectory. Send date parameters with FilesInsertRequest. TBR=benwells@chromium.org for chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc BUG=340553 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -15 lines) Patch
M chrome/browser/chromeos/drive/file_system/search_operation_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/drive/drive_api_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/drive/drive_api_service.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/drive/drive_service_interface.h View 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/drive/drive_service_interface.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/drive/dummy_drive_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/drive/dummy_drive_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/drive/fake_drive_service_unittest.cc View 7 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/drive/gdata_wapi_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/drive/gdata_wapi_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_uploader.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_uploader.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/folder_creator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/api_util.cc View 2 chunks +18 lines, -14 lines 0 comments Download
M google_apis/drive/drive_api_requests.h View 2 chunks +14 lines, -0 lines 0 comments Download
M google_apis/drive/drive_api_requests.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M google_apis/drive/drive_api_requests_unittest.cc View 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
hashimoto
tzik: Please review chrome/browser/sync_file_system kinaba: Please review other parts
6 years, 10 months ago (2014-02-04 09:10:28 UTC) #1
tzik
lgtm
6 years, 10 months ago (2014-02-04 13:29:37 UTC) #2
kinaba
lgtm
6 years, 10 months ago (2014-02-05 01:36:35 UTC) #3
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 10 months ago (2014-02-05 01:47:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/140513008/1
6 years, 10 months ago (2014-02-05 03:49:36 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 04:41:08 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=48166
6 years, 10 months ago (2014-02-05 04:41:09 UTC) #7
hashimoto
TBRing benwells@chromium.org for chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc
6 years, 10 months ago (2014-02-05 05:44:02 UTC) #8
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 10 months ago (2014-02-05 05:44:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/140513008/1
6 years, 10 months ago (2014-02-05 05:53:11 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 08:15:55 UTC) #11
Message was sent while issue was closed. 
Change committed as 248916

Powered by Google App Engine
This is Rietveld 408576698