Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: cc/layers/picture_layer_impl_unittest.cc

Issue 140513006: cc: Simplify picture layer tiling update tile priorities. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/picture_layer_impl.cc ('k') | cc/resources/managed_tile_state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/picture_layer_impl_unittest.cc
diff --git a/cc/layers/picture_layer_impl_unittest.cc b/cc/layers/picture_layer_impl_unittest.cc
index c3b569d1643be96ae08d6a88637549749fe6b59b..914e112d88ba0c5b8c76ac3ea31bb7f0721a14fe 100644
--- a/cc/layers/picture_layer_impl_unittest.cc
+++ b/cc/layers/picture_layer_impl_unittest.cc
@@ -1195,7 +1195,7 @@ TEST_F(PictureLayerImplTest, MarkRequiredNullTiles) {
TEST_F(PictureLayerImplTest, MarkRequiredOffscreenTiles) {
vmpstr 2014/02/03 20:27:24 This change is due to the mark required function n
gfx::Size tile_size(100, 100);
- gfx::Size layer_bounds(200, 100);
+ gfx::Size layer_bounds(200, 200);
scoped_refptr<FakePicturePileImpl> pending_pile =
FakePicturePileImpl::CreateFilledPile(tile_size, layer_bounds);
@@ -1207,12 +1207,14 @@ TEST_F(PictureLayerImplTest, MarkRequiredOffscreenTiles) {
host_impl_.pending_tree()->UpdateDrawProperties();
EXPECT_EQ(tiling->resolution(), HIGH_RESOLUTION);
+ pending_layer_->draw_properties().visible_content_rect =
+ gfx::Rect(0, 0, 100, 200);
+
// Fake set priorities.
- int tile_count = 0;
for (PictureLayerTiling::CoverageIterator iter(
tiling,
pending_layer_->contents_scale_x(),
- gfx::Rect(pending_layer_->visible_content_rect()));
+ gfx::Rect(layer_bounds));
iter;
++iter) {
if (!*iter)
@@ -1220,12 +1222,13 @@ TEST_F(PictureLayerImplTest, MarkRequiredOffscreenTiles) {
Tile* tile = *iter;
TilePriority priority;
priority.resolution = HIGH_RESOLUTION;
- if (++tile_count % 2) {
- priority.time_to_visible_in_seconds = 0.f;
- priority.distance_to_visible_in_pixels = 0.f;
+ gfx::Rect tile_bounds = iter.geometry_rect();
+ if (pending_layer_->visible_content_rect().Intersects(tile_bounds)) {
+ priority.priority_bin = TilePriority::NOW;
+ priority.distance_to_visible = 0.f;
} else {
- priority.time_to_visible_in_seconds = 1.f;
- priority.distance_to_visible_in_pixels = 1.f;
+ priority.priority_bin = TilePriority::SOON;
+ priority.distance_to_visible = 1.f;
}
tile->SetPriority(PENDING_TREE, priority);
}
@@ -1238,13 +1241,13 @@ TEST_F(PictureLayerImplTest, MarkRequiredOffscreenTiles) {
for (PictureLayerTiling::CoverageIterator iter(
tiling,
pending_layer_->contents_scale_x(),
- gfx::Rect(pending_layer_->visible_content_rect()));
+ gfx::Rect(layer_bounds));
iter;
++iter) {
if (!*iter)
continue;
const Tile* tile = *iter;
- if (tile->priority(PENDING_TREE).distance_to_visible_in_pixels == 0.f) {
+ if (tile->priority(PENDING_TREE).distance_to_visible == 0.f) {
EXPECT_TRUE(tile->required_for_activation());
num_visible++;
} else {
« no previous file with comments | « cc/layers/picture_layer_impl.cc ('k') | cc/resources/managed_tile_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698