Issue 1405103002: Dart: Merge message pipe query and read into one native call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1405103002: Dart: Merge message pipe query and read into one native call. (Closed)

Created:
5 years, 2 months ago by zra

Modified:
5 years, 2 months ago

Reviewers:
Cutch

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Dart: Merge message pipe query and read into one native call. Eliminates a crossing in and out of native code, and exposes an opportunity to eliminate some allocations in the future if that turns out to be useful. BUG= R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/1d0b6c4abb44e17370976a6d03f1e78c2098c736

Patch Set 1 #

Patch Set 2 : Format #

Patch Set 3 : #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+204 lines, -78 lines)			Patch
M	examples/dart/mojo_rtt_benchmark/lib/main.dart	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
M	mojo/dart/embedder/mojo_natives.cc	View	1	2 chunks	+63 lines, -0 lines	0 comments	Download
M	mojo/public/dart/mojo/lib/src/codec.dart	View	1 2	12 chunks	+70 lines, -47 lines	0 comments	Download
M	mojo/public/dart/mojo/lib/src/message.dart	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
M	mojo/public/dart/mojo/lib/src/message_pipe.dart	View	1	2 chunks	+42 lines, -0 lines	0 comments	Download
M	mojo/public/dart/mojo/lib/src/proxy.dart	View		1 chunk	+6 lines, -10 lines	0 comments	Download
M	mojo/public/dart/mojo/lib/src/stub.dart	View		1 chunk	+8 lines, -13 lines	0 comments	Download
M	mojo/public/dart/mojo/sdk_ext/src/natives.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	mojo/public/tools/bindings/generators/dart_templates/struct_definition.tmpl	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zra

5 years, 2 months ago (2015-10-16 15:46:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
1d0b6c4abb44e17370976a6d03f1e78c2098c736 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages