win: Lower integrity level of connection pipe

util/win/scoped_local_free.h

+// Copyright 2015 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef CRASHPAD_UTIL_WIN_SCOPED_LOCAL_FREE_H_
+#define CRASHPAD_UTIL_WIN_SCOPED_LOCAL_FREE_H_
+
+namespace crashpad {
+
+struct LocalFreeTraits {
+  static HLOCAL InvalidValue() { return nullptr; }

[Mark Mentovai, 2015/11/06 14:55:48]

#include <windows.h>

[scottmg, 2015/11/06 18:03:30]

Done.

+  static void Free(HLOCAL mem) {
+    if (LocalFree(mem) != nullptr)
+      PLOG(ERROR) << "LocalFree";

[Mark Mentovai, 2015/11/06 14:55:48]

Logging stuff compiles to more than anyone ever expects. Provide a .cc and
#include base/logging.h. This can also optionally use PLOG_IF.

[scottmg, 2015/11/06 18:03:30]

Done.

+  }
+};
+
+using ScopedLocalFree = base::ScopedGeneric<HLOCAL, LocalFreeTraits>;

[Mark Mentovai, 2015/11/06 14:55:48]

#include base/scoped_generic.h.

[Mark Mentovai, 2015/11/06 14:55:48]

We also have another user of this that I added a couple of days ago in
util/win/command_line_test.cc. That one is called ScopedLocalAlloc, but it’s the
same thing. (ScopedLocalAlloc may be a better name, because we usually name the
scopers after the thing they own, not the thing they do when they’re destroyed,
but it’s your call.)

[scottmg, 2015/11/06 18:03:30]

Done.

[scottmg, 2015/11/06 18:03:30]

Done, switched to ScopedLocalAlloc.

+
+}  // namespace crashpad
+
+#endif  // CRASHPAD_UTIL_WIN_SCOPED_LOCAL_FREE_H_