Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1405093012: [iOS] Add InMemoryURLIndexFactory::GetDefaultFactory() (Closed)

Created:
5 years, 1 month ago by droger
Modified:
5 years, 1 month ago
Reviewers:
sdefresne
CC:
chromium-reviews, sdefresne+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Add InMemoryURLIndexFactory::GetDefaultFactory() This function is useful for tests. Committed: https://crrev.com/a8bc3ee21edfe7aeceb4264ddbeaf026bed4c44a Cr-Commit-Position: refs/heads/master@{#358080}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -18 lines) Patch
M ios/chrome/browser/autocomplete/in_memory_url_index_factory.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ios/chrome/browser/autocomplete/in_memory_url_index_factory.cc View 1 2 chunks +30 lines, -16 lines 0 comments Download
M ios/chrome/browser/search_engines/template_url_service_factory.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
droger
5 years, 1 month ago (2015-11-05 14:05:53 UTC) #3
sdefresne
lgtm once formatting comment is addressed https://codereview.chromium.org/1405093012/diff/1/ios/chrome/browser/autocomplete/in_memory_url_index_factory.cc File ios/chrome/browser/autocomplete/in_memory_url_index_factory.cc (right): https://codereview.chromium.org/1405093012/diff/1/ios/chrome/browser/autocomplete/in_memory_url_index_factory.cc#newcode42 ios/chrome/browser/autocomplete/in_memory_url_index_factory.cc:42: } You need ...
5 years, 1 month ago (2015-11-05 14:58:59 UTC) #4
droger
Thanks, done.
5 years, 1 month ago (2015-11-05 17:35:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405093012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405093012/20001
5 years, 1 month ago (2015-11-05 17:36:04 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-05 18:04:01 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 18:04:49 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a8bc3ee21edfe7aeceb4264ddbeaf026bed4c44a
Cr-Commit-Position: refs/heads/master@{#358080}

Powered by Google App Engine
This is Rietveld 408576698