Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1405083003: Fix memory leaks in chrome/browser/chromeos/extensions/default_app_order.cc (Closed)

Created:
5 years, 2 months ago by Olli Raula
Modified:
5 years, 2 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix memory leaks in chrome/browser/chromeos/extensions/default_app_order.cc Fix memory leak from chrome/browser/chromeos/extensions/default_app_order.cc by using more scoped:ptr. Same time made fuctions simpler and one function to return scoped_ptr as caller used it that way already. BUG=543015 Committed: https://crrev.com/8cfd9626b3e4ad0fa3822d3ca9da5791d6804247 Cr-Commit-Position: refs/heads/master@{#354734}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/browser/chromeos/extensions/default_app_order.cc View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Olli Raula
Could you review
5 years, 2 months ago (2015-10-16 11:14:59 UTC) #2
Finnur
LGTM
5 years, 2 months ago (2015-10-16 11:50:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405083003/1
5 years, 2 months ago (2015-10-19 06:57:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 07:21:05 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 07:22:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8cfd9626b3e4ad0fa3822d3ca9da5791d6804247
Cr-Commit-Position: refs/heads/master@{#354734}

Powered by Google App Engine
This is Rietveld 408576698