Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 1405053002: SkTHash: hash from fnptr to functor type (Closed)

Created:
5 years, 2 months ago by mtklein_C
Modified:
5 years, 2 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkTHash: hash from fnptr to functor type Passing &SkGoodHash to SkTHashMap and SkTHashSet doesn't guarantee that it's actually instantiated. Using a functor does. BUG=skia: Committed: https://skia.googlesource.com/skia/+/c8d1dd48c01f562cfffe64da0e5cee5ed2713541

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -28 lines) Patch
M dm/DM.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M include/private/SkChecksum.h View 1 chunk +12 lines, -9 lines 0 comments Download
M include/private/SkTHash.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/pdf/SkPDFCanon.h View 1 chunk +6 lines, -4 lines 0 comments Download
M tests/ChecksumTest.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/HashTest.cpp View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405053002/1
5 years, 2 months ago (2015-10-15 18:36:59 UTC) #2
mtklein_C
5 years, 2 months ago (2015-10-15 18:40:19 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-15 18:46:03 UTC) #6
bungeman-skia
lgtm
5 years, 2 months ago (2015-10-15 19:18:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405053002/1
5 years, 2 months ago (2015-10-15 19:22:29 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 19:23:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c8d1dd48c01f562cfffe64da0e5cee5ed2713541

Powered by Google App Engine
This is Rietveld 408576698