Revert of [heap] remove unneeded call to LowerInlineAllocationLimit

Revert of [heap] remove unneeded call to LowerInlineAllocationLimit (patchset #2 id:20001 of https://codereview.chromium.org/1390013002/ )

Reason for revert:
Causes memory footprint regression: https://code.google.com/p/chromium/issues/detail?id=541135

The intent of the code here was to advance the inline allocation limit without counting the allocated memory towards a step. Calling LowerInlineAllocationLimit this way is a blunt way of doing it, but it works.

At this point it is simplest to revert this CL. My follow-on CL (https://codereview.chromium.org/1404523002/) can address the 'bluntness' of calling LowerInlineAllocationLimit from here along with leaving a comment about the intent.

revert_cq: 1
revert_reason_textarea: Causes memory footprint regression: https://code.google.com/p/chromium/issues/detail?id=541135

The intent of the code here was to advance the inline allocation limit without counting the allocated memory towards a step. Calling LowerInlineAllocationLimit this way is a blunt way of doing it, but it works.

At this point it is simplest to revert this CL. My follow-on CL (https://codereview.chromium.org/1404523002/) can address the 'bluntness' of calling LowerInlineAllocationLimit from here along with leaving a comment about the intent.

Original issue's description:
> [heap] remove unneeded call to LowerInlineAllocationLimit
>
> Calling LowerInlineAllocationLimit from the bottom of Heap::Scavenge seems to be
> a no-op.
>
>   new_space_.LowerInlineAllocationLimit(
>       new_space_.inline_allocation_limit_step());
>
> LowerInlineAllocatoinLimit does the following things:
>
> 1. Set the inline_allocation_limit_step_ to the passed in value. No-op.
> 2. Calls UpdateInlineAllocationLimit(0). This is unnecessary here as it has
>    already been called when new_space_.ResetAllocationInfo was called above.
> 3. Sets top_on_previous_step_. This again is unnecessary as it gets reached by
>    ResetAllocationInfo as well.
>
> BUG=
> R=hpayer@chromium.org,ulan@chromium.org
>
> Committed: https://crrev.com/9f8e8b835a468b1622c5350a01a97bc32c5b2fb7
> Cr-Commit-Position: refs/heads/master@{#31156}

TBR=hpayer@chromium.org,ulan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:541135
LOG=n

Committed: https://crrev.com/cf050cc2d2c212729874ca8b237ced9cf576a95c
Cr-Commit-Position: refs/heads/master@{#31574}

[ofrobots, 2015-10-25 10:18:27]

Created Revert of [heap] remove unneeded call to LowerInlineAllocationLimit

[commit-bot: I haz the power, 2015-10-25 10:18:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1405043005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1405043005/1

[commit-bot: I haz the power, 2015-10-25 10:18:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-25 10:18:38]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[ulan, 2015-10-26 09:32:21]

lgtm

[Hannes Payer (out of office), 2015-10-26 09:37:42]

lgtm

[Hannes Payer (out of office), 2015-10-26 11:45:57]

Description was changed from

==========
Revert of [heap] remove unneeded call to LowerInlineAllocationLimit (patchset #2
id:20001 of https://codereview.chromium.org/1390013002/ )

Reason for revert:
Causes memory footprint regression:
https://code.google.com/p/chromium/issues/detail?id=541135

The intent of the code here was to advance the inline allocation limit without
counting the allocated memory towards a step. Calling LowerInlineAllocationLimit
this way is a blunt way of doing it, but it works.

At this point it is simplest to revert this CL. My follow-on CL
(https://codereview.chromium.org/1404523002/) can address the 'bluntness' of
calling LowerInlineAllocationLimit from here along with leaving a comment about
the intent.

revert_cq: 1
revert_reason_textarea: Causes memory footprint regression:
https://code.google.com/p/chromium/issues/detail?id=541135

The intent of the code here was to advance the inline allocation limit without
counting the allocated memory towards a step. Calling LowerInlineAllocationLimit
this way is a blunt way of doing it, but it works.

At this point it is simplest to revert this CL. My follow-on CL
(https://codereview.chromium.org/1404523002/) can address the 'bluntness' of
calling LowerInlineAllocationLimit from here along with leaving a comment about
the intent.

Original issue's description:
> [heap] remove unneeded call to LowerInlineAllocationLimit
> 
> Calling LowerInlineAllocationLimit from the bottom of Heap::Scavenge seems to
be
> a no-op.
> 
>   new_space_.LowerInlineAllocationLimit(
>       new_space_.inline_allocation_limit_step());
> 
> LowerInlineAllocatoinLimit does the following things:
> 
> 1. Set the inline_allocation_limit_step_ to the passed in value. No-op.
> 2. Calls UpdateInlineAllocationLimit(0). This is unnecessary here as it has
>    already been called when new_space_.ResetAllocationInfo was called above.
> 3. Sets top_on_previous_step_. This again is unnecessary as it gets reached by
>    ResetAllocationInfo as well.
> 
> BUG=
> R=hpayer@chromium.org,ulan@chromium.org
> 
> Committed: https://crrev.com/9f8e8b835a468b1622c5350a01a97bc32c5b2fb7
> Cr-Commit-Position: refs/heads/master@{#31156}

TBR=hpayer@chromium.org,ulan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
==========

to

==========
Revert of [heap] remove unneeded call to LowerInlineAllocationLimit (patchset #2
id:20001 of https://codereview.chromium.org/1390013002/ )

Reason for revert:
Causes memory footprint regression:
https://code.google.com/p/chromium/issues/detail?id=541135

The intent of the code here was to advance the inline allocation limit without
counting the allocated memory towards a step. Calling LowerInlineAllocationLimit
this way is a blunt way of doing it, but it works.

At this point it is simplest to revert this CL. My follow-on CL
(https://codereview.chromium.org/1404523002/) can address the 'bluntness' of
calling LowerInlineAllocationLimit from here along with leaving a comment about
the intent.

revert_cq: 1
revert_reason_textarea: Causes memory footprint regression:
https://code.google.com/p/chromium/issues/detail?id=541135

The intent of the code here was to advance the inline allocation limit without
counting the allocated memory towards a step. Calling LowerInlineAllocationLimit
this way is a blunt way of doing it, but it works.

At this point it is simplest to revert this CL. My follow-on CL
(https://codereview.chromium.org/1404523002/) can address the 'bluntness' of
calling LowerInlineAllocationLimit from here along with leaving a comment about
the intent.

Original issue's description:
> [heap] remove unneeded call to LowerInlineAllocationLimit
> 
> Calling LowerInlineAllocationLimit from the bottom of Heap::Scavenge seems to
be
> a no-op.
> 
>   new_space_.LowerInlineAllocationLimit(
>       new_space_.inline_allocation_limit_step());
> 
> LowerInlineAllocatoinLimit does the following things:
> 
> 1. Set the inline_allocation_limit_step_ to the passed in value. No-op.
> 2. Calls UpdateInlineAllocationLimit(0). This is unnecessary here as it has
>    already been called when new_space_.ResetAllocationInfo was called above.
> 3. Sets top_on_previous_step_. This again is unnecessary as it gets reached by
>    ResetAllocationInfo as well.
> 
> BUG=
> R=hpayer@chromium.org,ulan@chromium.org
> 
> Committed: https://crrev.com/9f8e8b835a468b1622c5350a01a97bc32c5b2fb7
> Cr-Commit-Position: refs/heads/master@{#31156}

TBR=hpayer@chromium.org,ulan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=541135
LOG=n
==========

[Hannes Payer (out of office), 2015-10-26 11:46:10]

Description was changed from

==========
Revert of [heap] remove unneeded call to LowerInlineAllocationLimit (patchset #2
id:20001 of https://codereview.chromium.org/1390013002/ )

Reason for revert:
Causes memory footprint regression:
https://code.google.com/p/chromium/issues/detail?id=541135

The intent of the code here was to advance the inline allocation limit without
counting the allocated memory towards a step. Calling LowerInlineAllocationLimit
this way is a blunt way of doing it, but it works.

At this point it is simplest to revert this CL. My follow-on CL
(https://codereview.chromium.org/1404523002/) can address the 'bluntness' of
calling LowerInlineAllocationLimit from here along with leaving a comment about
the intent.

revert_cq: 1
revert_reason_textarea: Causes memory footprint regression:
https://code.google.com/p/chromium/issues/detail?id=541135

The intent of the code here was to advance the inline allocation limit without
counting the allocated memory towards a step. Calling LowerInlineAllocationLimit
this way is a blunt way of doing it, but it works.

At this point it is simplest to revert this CL. My follow-on CL
(https://codereview.chromium.org/1404523002/) can address the 'bluntness' of
calling LowerInlineAllocationLimit from here along with leaving a comment about
the intent.

Original issue's description:
> [heap] remove unneeded call to LowerInlineAllocationLimit
> 
> Calling LowerInlineAllocationLimit from the bottom of Heap::Scavenge seems to
be
> a no-op.
> 
>   new_space_.LowerInlineAllocationLimit(
>       new_space_.inline_allocation_limit_step());
> 
> LowerInlineAllocatoinLimit does the following things:
> 
> 1. Set the inline_allocation_limit_step_ to the passed in value. No-op.
> 2. Calls UpdateInlineAllocationLimit(0). This is unnecessary here as it has
>    already been called when new_space_.ResetAllocationInfo was called above.
> 3. Sets top_on_previous_step_. This again is unnecessary as it gets reached by
>    ResetAllocationInfo as well.
> 
> BUG=
> R=hpayer@chromium.org,ulan@chromium.org
> 
> Committed: https://crrev.com/9f8e8b835a468b1622c5350a01a97bc32c5b2fb7
> Cr-Commit-Position: refs/heads/master@{#31156}

TBR=hpayer@chromium.org,ulan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=541135
LOG=n
==========

to

==========
Revert of [heap] remove unneeded call to LowerInlineAllocationLimit (patchset #2
id:20001 of https://codereview.chromium.org/1390013002/ )

Reason for revert:
Causes memory footprint regression:
https://code.google.com/p/chromium/issues/detail?id=541135

The intent of the code here was to advance the inline allocation limit without
counting the allocated memory towards a step. Calling LowerInlineAllocationLimit
this way is a blunt way of doing it, but it works.

At this point it is simplest to revert this CL. My follow-on CL
(https://codereview.chromium.org/1404523002/) can address the 'bluntness' of
calling LowerInlineAllocationLimit from here along with leaving a comment about
the intent.

revert_cq: 1
revert_reason_textarea: Causes memory footprint regression:
https://code.google.com/p/chromium/issues/detail?id=541135

The intent of the code here was to advance the inline allocation limit without
counting the allocated memory towards a step. Calling LowerInlineAllocationLimit
this way is a blunt way of doing it, but it works.

At this point it is simplest to revert this CL. My follow-on CL
(https://codereview.chromium.org/1404523002/) can address the 'bluntness' of
calling LowerInlineAllocationLimit from here along with leaving a comment about
the intent.

Original issue's description:
> [heap] remove unneeded call to LowerInlineAllocationLimit
> 
> Calling LowerInlineAllocationLimit from the bottom of Heap::Scavenge seems to
be
> a no-op.
> 
>   new_space_.LowerInlineAllocationLimit(
>       new_space_.inline_allocation_limit_step());
> 
> LowerInlineAllocatoinLimit does the following things:
> 
> 1. Set the inline_allocation_limit_step_ to the passed in value. No-op.
> 2. Calls UpdateInlineAllocationLimit(0). This is unnecessary here as it has
>    already been called when new_space_.ResetAllocationInfo was called above.
> 3. Sets top_on_previous_step_. This again is unnecessary as it gets reached by
>    ResetAllocationInfo as well.
> 
> BUG=
> R=hpayer@chromium.org,ulan@chromium.org
> 
> Committed: https://crrev.com/9f8e8b835a468b1622c5350a01a97bc32c5b2fb7
> Cr-Commit-Position: refs/heads/master@{#31156}

TBR=hpayer@chromium.org,ulan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:541135
LOG=n
==========

[ofrobots, 2015-10-26 15:25:31]

The CQ bit was checked by ofrobots@google.com

[commit-bot: I haz the power, 2015-10-26 15:25:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1405043005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1405043005/1

[commit-bot: I haz the power, 2015-10-26 15:25:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-26 15:26:15]

Patchset 1 (id:??) landed as
https://crrev.com/cf050cc2d2c212729874ca8b237ced9cf576a95c
Cr-Commit-Position: refs/heads/master@{#31574}