Scripts to generate Android.mk for framework Skia.

platform_tools/android/gyp_gen/gypd_parser.py

Index: platform_tools/android/gyp_gen/gypd_parser.py
diff --git a/platform_tools/android/gyp_gen/gypd_parser.py b/platform_tools/android/gyp_gen/gypd_parser.py
new file mode 100644
index 0000000000000000000000000000000000000000..4d357c54f4aaefae1c96183159a04780be7c1a60
--- /dev/null
+++ b/platform_tools/android/gyp_gen/gypd_parser.py
@@ -0,0 +1,122 @@
+#!/usr/bin/python
+
+# Copyright 2014 Google Inc.
+#
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""
+Functions for parsing the gypd output from gyp.
+"""
+
+import vars_dict_lib
+
+def parse_dictionary(var_dict, d, current_target_name):
+  """
+  Helper function to get the meaningful entries in a dictionary.
+  @param var_dict VarsDict object for storing the results of the parsing.

[epoger, 2014/02/03 17:26:32]

I think it's unusual for Python functions to take an "out" variable like this,
instead of just returning a VarsDict.  But it should be fine.

[scroggo, 2014/02/03 23:22:31]

Hmm. The reason I do it this way is because this function recurses, and I want
to keep adding entries to the same VarsDict, rather than creating a new one. Is
there another way you'd recommend?

[epoger, 2014/02/04 15:00:12]

I guess the alternative would be to collect multiple VarsDicts and combine them.
 But I think it's fine to do it this way, just a little unusual in Python (in my
huuuuge Python experience)

+  @param d Dictionary object to parse.
+  @param current_target_name The current target being parsed. If this
+                             dictionary is a target, this will be its entry
+                             'target_name'. Otherwise, this will be the name of
+                             the target which contains this dictionary.
+  """
+  for source in d.get('sources', []):
+    if source.endswith('.h'):

[epoger, 2014/02/03 17:26:32]

Do we need to worry about capitalization?  (Is it possible that there might be
header files ending with '.H', and similar for .gypi files?)

[scroggo, 2014/02/03 23:22:31]

Well, someone could easily rewrite our gyp files to use capital letters. It's
easy enough to compare against a lowercase version of source. Done.

+      # Android.mk does not need the header files.
+      continue
+    if source.endswith('gypi'):
+      # The gypi files are included in sources, but the sources they included
+      # are also included. No need to parse them again.
+      continue
+    # The path is relative to the gyp folder, but Android wants the path
+    # relative to the root.
+    source = source.replace('../src', 'src', 1)

[epoger, 2014/02/03 17:26:32]

Does this modify the dictionary in place?  If so, I think you should warn
callers in the function docstring.  Or even better, stop doing so. :-)

Edit: Looking at http://docs.python.org/2/library/string.html#string.replace , I
guess not.  replace() creates a copy of the original "source" string, and unless
you call d.set(), I guess d remains unchanged regardless of your reassignation
of "source" to point at a new string.

[scroggo, 2014/02/03 23:22:31]

That's correct. And I do not call d.set :)

+    var_dict.LOCAL_SRC_FILES.add(source)
+
+  for lib in d.get('libraries', []):
+    if lib.endswith('.a'):
+      # Remove the '.a'
+      lib = lib[:-2]
+      # Add 'lib', if necessary
+      if not lib.startswith('lib'):
+        lib = 'lib' + lib
+      var_dict.LOCAL_STATIC_LIBRARIES.add(lib)
+    else:
+      # lib will be in the form of '-l<name>'. Change it to 'lib<name>'
+      lib = lib.replace('-l', 'lib', 1)
+      var_dict.LOCAL_SHARED_LIBRARIES.add(lib)
+
+  for dependency in d.get('dependencies', []):
+    # Each dependency is listed as
+    #   <path_to_file>:<target>#target
+    li = dependency.split(':')
+    assert(len(li) <= 2 and len(li) >= 1)
+    sub_targets = []
+    if len(li) == 2 and li[1] != '*':
+      sub_targets.append(li[1].split('#')[0])
+    sub_path = li[0]
+    assert(sub_path.endswith('.gyp'))
+    # Although the original reference is to a .gyp, parse the corresponding
+    # gypd file, which was constructed by gyp.
+    sub_path = sub_path + 'd'
+    parse_gypd(var_dict, sub_path, sub_targets)
+
+  if 'default_configuration' in d:
+    config_name = d['default_configuration']
+    # default_configuration is meaningless without configurations
+    assert('configurations' in d)
+    config = d['configurations'][config_name]
+    parse_dictionary(var_dict, config, current_target_name)
+
+  for flag in d.get('cflags', []):
+    var_dict.LOCAL_CFLAGS.add(flag)
+  for flag in d.get('cflags_cc', []):
+    var_dict.LOCAL_CPPFLAGS.add(flag)
+
+  for include in d.get('include_dirs', []):
+    # The input path will be relative to gyp/, but Android wants relative to

[epoger, 2014/02/03 17:26:32]

I worry that some of these adjustments will prove to be fragile over time, but I
guess we'll cross that bridge if/when we come to it.

+    # LOCAL_PATH
+    include = include.replace('..', '$(LOCAL_PATH)', 1)
+    # Remove a trailing slash, if present.
+    if include.endswith('/'):
+      include = include[:-1]
+    var_dict.LOCAL_C_INCLUDES.add(include)
+    # For the top level, libskia, include directories should be exported.
+    if current_target_name == 'libskia':
+      var_dict.LOCAL_EXPORT_C_INCLUDE_DIRS.add(include)
+
+  for define in d.get('defines', []):
+    var_dict.LOCAL_CFLAGS.add('-D' + define)
+
+
+def parse_gypd(var_dict, path, desired_targets=None):
+  """
+  Parse a gypd file.
+  @param var_dict VarsDict object for storing the result of the parse.
+  @param path Path to gypd file.
+  @param desired_targets List of targets to be parsed from this file. If empty,
+                         parse all targets.
+  """
+  d = {}
+  with open(path, 'r') as f:
+    # Read the entire file as a dictionary
+    d = eval(f.read())
+  # The gypd file is structured such that the top level dictionary has an entry
+  # named 'targets'

[epoger, 2014/02/03 17:26:32]

And if it doesn't have a 'targets' entry, shouldn't you allow that to raise an
Exception rather than returning quietly?

If so, you could replace lines 107-110 with:

for target in d['targets']:

[scroggo, 2014/02/03 23:22:31]

Done.

+  if 'targets' not in d:
+    return
+  targets = d['targets']
+  for target in targets:
+    target_name = target['target_name']
+    if target_name in var_dict.KNOWN_TARGETS:
+      # Avoid circular dependencies
+      continue
+    if desired_targets and target_name not in desired_targets:
+      # Our caller does not depend on this one
+      continue
+    # Add it to our known targets so we don't parse it again
+    var_dict.KNOWN_TARGETS.add(target_name)
+
+    parse_dictionary(var_dict, target, target_name)
+