Issue 140503005: Mojo: foo_[0-9] -> foo[0-9].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140503005: Mojo: foo_[0-9] -> foo[0-9]. (Closed)

Created:
6 years, 11 months ago by viettrungluu

Modified:
6 years, 11 months ago

Reviewers:
sky

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Mojo: foo_[0-9] -> foo[0-9]. For foolish consistency. I'll never make this mistake again. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245573

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+471 lines, -474 lines)			Patch
M	mojo/public/system/core_cpp.h	View	1 chunk	+9 lines, -9 lines	0 comments	Download
M	mojo/public/tests/system/core_cpp_unittest.cc	View	9 chunks	+134 lines, -135 lines	0 comments	Download
M	mojo/public/tests/system/core_perftest.cc	View	5 chunks	+14 lines, -14 lines	0 comments	Download
M	mojo/public/tests/system/core_unittest.cc	View	2 chunks	+23 lines, -24 lines	0 comments	Download
M	mojo/system/core_impl.cc	View	2 chunks	+6 lines, -8 lines	0 comments	Download
M	mojo/system/core_impl_unittest.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	mojo/system/message_pipe.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	mojo/system/message_pipe.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	mojo/system/message_pipe_dispatcher_unittest.cc	View	9 chunks	+119 lines, -119 lines	0 comments	Download
M	mojo/system/remote_message_pipe_posix_unittest.cc	View	10 chunks	+105 lines, -104 lines	0 comments	Download
M	mojo/system/waiter_list_unittest.cc	View	3 chunks	+49 lines, -49 lines	0 comments	Download

Total messages: 3 (0 generated)

viettrungluu

6 years, 11 months ago (2014-01-17 18:57:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r245573 (presubmit successful).