Issue 140503004: Make VTTRegion::setRegionSettings use VTTScanner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140503004: Make VTTRegion::setRegionSettings use VTTScanner (Closed)

Created:
6 years, 11 months ago by fs

Modified:
6 years, 11 months ago

Reviewers:
Mike West, jochen (gone - plz use gerrit)

CC:
blink-reviews, nessy, philipj_slow, gasubic, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Make VTTRegion::setRegionSettings use VTTScanner Next step in the transition of VTTRegion parsing code to VTTScanner. Convert VTTRegion::setRegionSettings, and fold VTTRegion::parseSetting into it. BUG=305317 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165399

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -28 lines)			Patch
	M	Source/core/html/track/vtt/VTTRegion.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	Source/core/html/track/vtt/VTTRegion.cpp	View		2 chunks	+20 lines, -27 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/140503004/1

6 years, 11 months ago (2014-01-20 09:59:42 UTC) #5

Message was sent while issue was closed.

Change committed as 165399

Expand Messages | Collapse Messages