Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1405023013: In BUILD.public, specify alwayslink for skia library. (Closed)

Created:
5 years, 1 month ago by dogben
Modified:
5 years, 1 month ago
Reviewers:
mtklein
CC:
jcgregorio, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

In BUILD.public, specify alwayslink for skia library. Some Skia classes use SkTRegistry, which requires the source files be linked in order to be registered. Also replace "*CG*" with "SkImageDecoder_CG.cpp" for clarity. BUG=skia: Committed: https://skia.googlesource.com/skia/+/9dbec092512ca2759b46e24850ffde40dee3029f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M BUILD.public View 5 chunks +3 lines, -2 lines 0 comments Download
M tools/BUILD.public.expected View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405023013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405023013/1
5 years, 1 month ago (2015-10-30 17:44:49 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-30 17:55:42 UTC) #4
dogben
5 years, 1 month ago (2015-10-30 17:57:30 UTC) #6
mtklein
lgtm
5 years, 1 month ago (2015-11-01 22:29:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405023013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405023013/1
5 years, 1 month ago (2015-11-02 13:43:14 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 13:53:42 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9dbec092512ca2759b46e24850ffde40dee3029f

Powered by Google App Engine
This is Rietveld 408576698