Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1405023004: dart2js cps: Prefer unlabeled continue over labeled break. (Closed)

Created:
5 years, 2 months ago by asgerf
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Prefer unlabeled continue over labeled break. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/9c0a7cd7303438a5212cefd104f0674c15f8faa5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 2 months ago (2015-10-20 18:14:19 UTC) #2
Kevin Millikin (Google)
lgtm
5 years, 2 months ago (2015-10-21 11:18:29 UTC) #3
asgerf
5 years, 2 months ago (2015-10-21 13:40:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9c0a7cd7303438a5212cefd104f0674c15f8faa5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698