Fix for Issue 3258: Tabs created when tabstrip is compressed pending resize r...

Fix for Issue 3258: Tabs created when tabstrip is compressed pending resize relayout should not force resize relayout.

This is proposed solution one from the comment#5 which is to
create new tabs without resizing existing tabs unless there is
no room for the new tab.

BUG=3258

[M-A Ruel, 2008-12-12 16:04:49]

http://codereview.chromium.org/14050/diff/1/2
File chrome/browser/views/tabs/tab_strip.cc (right):

http://codereview.chromium.org/14050/diff/1/2#newcode1475
Line 1475: int last_tab_index = GetTabCount()-2;
spaces

http://codereview.chromium.org/14050/diff/1/2#newcode1476
Line 1476: if (last_tab_index>0) {
spaces

http://codereview.chromium.org/14050/diff/1/2#newcode1477
Line 1477: Tab* last_tab = GetTabAt(last_tab_index);
alignment

http://codereview.chromium.org/14050/diff/1/2#newcode1480
Line 1480: width() - (kNewTabButtonHOffset + newtab_button_size_.width()));
80 cols

http://codereview.chromium.org/14050/diff/1/2#newcode1482
Line 1482: available_width_for_tabs_ = -1;
alignment
use brackets for else clause when the if has brackets.

[Peter Kasting, 2008-12-12 17:51:26]

Added Ben to reviewers list, he should look at this

[M-A Ruel, 2008-12-12 20:54:44]

And the patch went ok on the try server. Removing myself from reviewer.

[Ben Goodger (Google), 2009-01-15 19:00:47]

OK

[Mark Larson, 2009-01-21 19:14:22]

I think this change might be the cause of http://crbug.com/6585.

[Dooglius_gmail.com, 2009-01-24 03:04:25]

On 2009/01/21 19:14:22, Mark Larson (Google) wrote:
> I think this change might be the cause of http://crbug.com/6585.

I had the same problem (http://crbug.com/6962) and although I'm no expert
programmer, I think that it fails on line 1475 because the width of the newly
created tab is initialized to zero, and when the tab is created as the
penultimate tab, this causes the problem.

[Peter Kasting, 2009-03-27 18:49:22]

Is there a reason this is still open?  Can we delete/close?

[Peter Kasting, 2009-05-21 21:35:01]

OK, I'm closing this.