Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1404943002: Use import/export for more functions (instead of js builtins object). (Closed)

Created:
5 years, 2 months ago by Yang
Modified:
5 years, 2 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use import/export for more functions (instead of js builtins object). R=cbruni@chromium.org Committed: https://crrev.com/558f1441c6e674a4d045220696383c8c8753d950 Cr-Commit-Position: refs/heads/master@{#31285}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -98 lines) Patch
M src/bootstrapper.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/debug/mirrors.js View 5 chunks +16 lines, -6 lines 0 comments Download
M src/js/array-iterator.js View 2 chunks +3 lines, -3 lines 0 comments Download
M src/js/arraybuffer.js View 1 chunk +3 lines, -1 line 0 comments Download
M src/js/collection.js View 3 chunks +5 lines, -7 lines 0 comments Download
M src/js/collection-iterator.js View 3 chunks +9 lines, -10 lines 0 comments Download
M src/js/date.js View 11 chunks +16 lines, -17 lines 0 comments Download
M src/js/harmony-sharedarraybuffer.js View 1 chunk +6 lines, -1 line 0 comments Download
M src/js/macros.py View 1 chunk +0 lines, -1 line 0 comments Download
M src/js/math.js View 5 chunks +5 lines, -4 lines 0 comments Download
M src/js/messages.js View 3 chunks +4 lines, -3 lines 0 comments Download
M src/js/object-observe.js View 5 chunks +8 lines, -7 lines 0 comments Download
M src/js/prologue.js View 3 chunks +6 lines, -0 lines 0 comments Download
M src/js/runtime.js View 2 chunks +4 lines, -4 lines 0 comments Download
M src/js/typedarray.js View 8 chunks +16 lines, -11 lines 0 comments Download
M src/js/v8natives.js View 4 chunks +4 lines, -3 lines 0 comments Download
M src/js/weak-collection.js View 8 chunks +17 lines, -7 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 2 months ago (2015-10-15 09:13:55 UTC) #1
Camillo Bruni
lgtm
5 years, 2 months ago (2015-10-15 09:39:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404943002/1
5 years, 2 months ago (2015-10-15 09:50:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 10:22:56 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 10:23:19 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/558f1441c6e674a4d045220696383c8c8753d950
Cr-Commit-Position: refs/heads/master@{#31285}

Powered by Google App Engine
This is Rietveld 408576698