Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 1404903004: [x64] Use vcvtlsi2sd when AVX is enabled (Closed)

Created:
5 years, 2 months ago by alph
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Use vcvtlsi2sd when AVX is enabled BUG=v8:4406 LOG=N Committed: https://crrev.com/adcbe619a959fe1d8f21d06fbf5984868c4f6b9a Cr-Commit-Position: refs/heads/master@{#31276} Committed: https://crrev.com/7cdcf0b1bc45777b48923e9758a3a30e8620c1a1 Cr-Commit-Position: refs/heads/master@{#31315}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix the test on Win64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -7 lines) Patch
M src/compiler/x64/code-generator-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/x64/disasm-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +16 lines, -4 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
alph
5 years, 2 months ago (2015-10-15 05:12:13 UTC) #2
Benedikt Meurer
LGTM with nits/questions. https://codereview.chromium.org/1404903004/diff/1/src/x64/macro-assembler-x64.cc File src/x64/macro-assembler-x64.cc (right): https://codereview.chromium.org/1404903004/diff/1/src/x64/macro-assembler-x64.cc#newcode796 src/x64/macro-assembler-x64.cc:796: xorps(dst, dst); Nit: Use xorpd for ...
5 years, 2 months ago (2015-10-15 05:13:47 UTC) #3
alph
https://codereview.chromium.org/1404903004/diff/1/src/x64/macro-assembler-x64.cc File src/x64/macro-assembler-x64.cc (right): https://codereview.chromium.org/1404903004/diff/1/src/x64/macro-assembler-x64.cc#newcode796 src/x64/macro-assembler-x64.cc:796: xorps(dst, dst); On 2015/10/15 05:13:47, Benedikt Meurer wrote: > ...
5 years, 2 months ago (2015-10-15 05:20:07 UTC) #4
Benedikt Meurer
On 2015/10/15 05:20:07, alph wrote: > https://codereview.chromium.org/1404903004/diff/1/src/x64/macro-assembler-x64.cc > File src/x64/macro-assembler-x64.cc (right): > > https://codereview.chromium.org/1404903004/diff/1/src/x64/macro-assembler-x64.cc#newcode796 > ...
5 years, 2 months ago (2015-10-15 05:20:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404903004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404903004/1
5 years, 2 months ago (2015-10-15 05:31:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 05:53:21 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/adcbe619a959fe1d8f21d06fbf5984868c4f6b9a Cr-Commit-Position: refs/heads/master@{#31276}
5 years, 2 months ago (2015-10-15 05:53:32 UTC) #9
alph
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1396283004/ by alph@chromium.org. ...
5 years, 2 months ago (2015-10-15 06:08:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404903004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404903004/20001
5 years, 2 months ago (2015-10-15 16:48:17 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/10674)
5 years, 2 months ago (2015-10-15 17:34:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404903004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404903004/20001
5 years, 2 months ago (2015-10-15 17:41:30 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-15 17:50:07 UTC) #18
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 17:50:48 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7cdcf0b1bc45777b48923e9758a3a30e8620c1a1
Cr-Commit-Position: refs/heads/master@{#31315}

Powered by Google App Engine
This is Rietveld 408576698