Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 14049021: 'length' property is invalid for some DOM bindings functions (Closed)

Created:
7 years, 8 months ago by do-not-use
Modified:
7 years, 8 months ago
CC:
blink-reviews, Nate Chapin, abarth-chromium, lgombos
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

'length' property is invalid for some DOM bindings functions The bindings generator only set the 'length' property for "standard" functions. This patch properly sets the 'length' properties for special functions as well (e.g. having EnabledPerContext or DoNotCheckSecurity extended attribute). NOTRY=true BUG=235011 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M LayoutTests/fast/js/function-length.html View 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/fast/js/function-length-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/bindings/scripts/CodeGeneratorV8.pm View 5 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
do-not-use
7 years, 8 months ago (2013-04-24 13:45:56 UTC) #1
arv (Not doing code reviews)
LGTM
7 years, 8 months ago (2013-04-24 13:52:43 UTC) #2
haraken
LGTM
7 years, 8 months ago (2013-04-24 14:04:47 UTC) #3
do-not-use
On 2013/04/24 14:04:47, haraken wrote: > LGTM Thanks for reviewing. Could someone please cq+ ? ...
7 years, 8 months ago (2013-04-24 14:45:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/14049021/1
7 years, 8 months ago (2013-04-24 14:49:06 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=5229
7 years, 8 months ago (2013-04-24 15:22:23 UTC) #6
do-not-use
On 2013/04/24 15:22:23, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 8 months ago (2013-04-25 06:06:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/14049021/1
7 years, 8 months ago (2013-04-25 06:14:13 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=5365
7 years, 8 months ago (2013-04-25 06:46:30 UTC) #9
do-not-use
On 2013/04/25 06:46:30, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 8 months ago (2013-04-25 08:24:46 UTC) #10
haraken
cq+ with NOTRY=true.
7 years, 8 months ago (2013-04-25 08:27:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/14049021/1
7 years, 8 months ago (2013-04-25 08:27:58 UTC) #12
commit-bot: I haz the power
7 years, 8 months ago (2013-04-25 08:28:17 UTC) #13
Message was sent while issue was closed.
Change committed as 149087

Powered by Google App Engine
This is Rietveld 408576698