Take noSuchMethod into account when computing the potential targets of a call.

tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart

Index: tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart
===================================================================
--- tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart	(revision 0)
+++ tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart	(revision 0)
@@ -0,0 +1,131 @@
+// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:expect/expect.dart';
+
+import 'compiler_helper.dart';
+import 'parser_helper.dart';
+
+const String TEST1 = """
+class A {
+  noSuchMethod(im) => 42;
+}
+
+class B extends A {
+  foo();
+}
+
+class C extends B {
+  foo() => {};
+}
+
+var a;
+test1() => new A().foo();
+test2() => a.foo();
+test3() => new B().foo();
+test4() => new C().foo();
+test5() => (a ? new A() : new B()).foo();
+test6() => (a ? new B() : new C()).foo();
+
+main() {
+  test1();
+  test2();
+  test3();
+  test4();
+  test5();
+  test6();
+}
+""";
+
+const String TEST2 = """
+abstract class A {
+  noSuchMethod(im) => 42;
+}
+
+class B extends A {
+  foo() => {};
+}
+
+class C extends B {
+  foo() => {};
+}
+
+class D implements A {
+  foo() => {};
+  noSuchMethod(im) => 42.5;
+}
+
+var a;
+test1() => a.foo();
+test2() => new B().foo();
+test3() => new C().foo();
+test4() => (a ? new B() : new C()).foo();
+test5() => (a ? new B() : new D()).foo();
+
+// Can hit A.noSuchMethod, D.noSuchMethod and Object.noSuchMethod.
+test6() => a.bar();
+
+// Can hit A.noSuchMethod.
+test7() => new B().bar();
+test8() => new C().bar();
+test9() => (a ? new B() : new C()).bar();
+
+// Can hit A.noSuchMethod, D.noSuchMethod and Object.noSuchMethod.
+test10() => (a ? new B() : new D()).bar();
+
+// Can hit D.noSuchMethod.
+test11() => new D().bar();
+

[karlklose, 2013/04/16 13:54:47]

Extra line.

[ngeoffray, 2013/04/17 09:11:18]

Done.

+
+main() {
+  test1();
+  test2();
+  test3();
+  test4();
+  test5();
+  test6();
+  test7();
+  test8();
+  test9();
+  test10();
+  test11();
+}
+""";
+
+main() {
+  Uri uri = new Uri.fromComponents(scheme: 'source');
+
+  var compiler = compilerFor(TEST1, uri);
+  compiler.runCompiler(uri);
+  var typesInferrer = compiler.typesTask.typesInferrer;
+
+  checkReturn(String name, type) {
+    var element = findElement(compiler, name);
+    Expect.equals(type, typesInferrer.returnTypeOf[element], name);
+  }
+
+  checkReturn('test1', typesInferrer.intType);
+  checkReturn('test2', typesInferrer.dynamicType);
+  checkReturn('test3', typesInferrer.intType);
+  checkReturn('test4', typesInferrer.mapType);
+  checkReturn('test5', typesInferrer.dynamicType);
+  checkReturn('test6', typesInferrer.dynamicType);
+
+  compiler = compilerFor(TEST2, uri);
+  compiler.runCompiler(uri);
+  typesInferrer = compiler.typesTask.typesInferrer;
+
+  checkReturn('test1', typesInferrer.dynamicType);
+  checkReturn('test2', typesInferrer.mapType);
+  checkReturn('test3', typesInferrer.mapType);
+  checkReturn('test4', typesInferrer.mapType);
+  checkReturn('test5', typesInferrer.mapType);
+
+  checkReturn('test6', typesInferrer.numType.nullable());

[karlklose, 2013/04/16 13:54:47]

Add a comment to remove .nullable() when we can track aborting control flow?

[ngeoffray, 2013/04/17 09:11:18]

Done.

+  checkReturn('test7', typesInferrer.intType);
+  checkReturn('test8', typesInferrer.intType);
+  checkReturn('test9', typesInferrer.intType);
+  checkReturn('test10', typesInferrer.numType.nullable());
+  checkReturn('test11', typesInferrer.doubleType);
+}