Issue 1404873003: relnote: Avoid redundant recvmmsg when the previous recvmmsg returned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1404873003: relnote: Avoid redundant recvmmsg when the previous recvmmsg returned (Closed)

Created:
5 years, 2 months ago by ramant (doing other things)

Modified:
5 years, 2 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@QUIC_test_tools_104305494

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

relnote: Avoid redundant recvmmsg when the previous recvmmsg returned less than the requested number of packets. Guarded by FLAGS_quic_read_packets_full_recvmmsg. This has no measurable effect on the QUIC microbenchmark, though it should avoid an extra call to recvmmsg at a minimum. Merge internal change: 104327020 R=rch@chromium.org

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -7 lines)			Patch
M	net/quic/quic_flags.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_flags.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/tools/quic/quic_packet_reader.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/tools/quic/quic_packet_reader.cc	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	net/tools/quic/quic_server.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Depends on Patchset:

Issue 1407473005 Patch 1

Dependent Patchsets:

Issue 1399893005 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages