Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h

Issue 1404853003: Add SVG Text to support the CSS 'text-orientation' property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: drott review Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h
diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h b/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h
index 469ee41c182f4ed6a8eff383aaedd28de9fb90a1..078cad7d4e513193ac108213fd5b5be43af2dc21 100644
--- a/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h
+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h
@@ -25,6 +25,7 @@
namespace blink {
+enum class FontOrientation;
class LayoutSVGInlineText;
class TextRun;
@@ -48,6 +49,9 @@ public:
void setWidth(float width) { m_width = width; }
float height() const { return m_height; }
+ // TODO(kojii): We should store logical width (advance) and height instead
+ // of storing physical and calculate logical. crbug.com/544767
+ float advance(FontOrientation) const;
unsigned length() const { return m_length; }
private:

Powered by Google App Engine
This is Rietveld 408576698