third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineBaseline.h - Issue 1404853003: Add SVG Text to support the CSS 'text-orientation' property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineBaseline.h

Issue 1404853003: Add SVG Text to support the CSS 'text-orientation' property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: drott review Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp ('k') | third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineBaseline.h

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineBaseline.h b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineBaseline.h

index 9c0a769c69a52fb2088a044bf657c2c330d00389..432776d8cf2b3f347c0774cd76b10f501844d656 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineBaseline.h

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineBaseline.h

@@ -42,8 +42,6 @@ public:

float calculateBaselineShift(const ComputedStyle&) const;

float calculateAlignmentBaselineShift(bool isVerticalText, const LayoutObject* textLayoutObject) const;

- float calculateGlyphOrientationAngle(bool isVerticalText, const SVGComputedStyle&, const UChar32 character) const;

- float calculateGlyphAdvanceAndOrientation(bool isVerticalText, const SVGTextMetrics&, float angle, float& xOrientationShift, float& yOrientationShift) const;

private:

EAlignmentBaseline dominantBaselineToAlignmentBaseline(bool isVerticalText, const LayoutObject* textLayoutObject) const;