Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

Issue 1404853003: Add SVG Text to support the CSS 'text-orientation' property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: drott review Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp
index e027a8641a1021bb30e698fc8563c5052d29847e..37e3fd3edb25ae5742f3ae81bbd88690735f90d0 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp
@@ -226,20 +226,6 @@ void LayoutSVGInlineText::computeNewScaledFontForStyle(LayoutObject* layoutObjec
ASSERT(style);
ASSERT(layoutObject);
- // layoutTextOnLineOrPath() expects fonts to do nothing for vertical flow so
- // that it can position each glyph precisely. Make sure the selected font is
- // the one for horizontal flow to not to break the assumption.
- // TODO(kojii): This might be done better by obsoleting the
- // 'glyph-orientation-vertical' property as recommended in:
- // https://drafts.csswg.org/css-writing-modes/#glyph-orientation
- if (style->font().fontDescription().orientation() != FontOrientation::Horizontal) {
- FontDescription description = style->font().fontDescription();
- FontSelector* fontSelector = style->font().fontSelector();
- description.setOrientation(FontOrientation::Horizontal);
- layoutObject->mutableStyleRef().setFontDescription(description);
- style->font().update(fontSelector);
- }
-
// Alter font-size to the right on-screen value to avoid scaling the glyphs themselves, except when GeometricPrecision is specified.
scalingFactor = SVGLayoutSupport::calculateScreenFontSizeScalingFactor(layoutObject);
if (style->effectiveZoom() == 1 && (scalingFactor == 1 || !scalingFactor)) {

Powered by Google App Engine
This is Rietveld 408576698